Skip to content

Conversation

fegin
Copy link
Contributor

@fegin fegin commented Jan 29, 2025

OptimizerWrapper currently miss several attributes that are required for training integration. This PR adds the missing gap.

OptimizerWrapper currently miss several attributes that are required for training integration. This PR adds the missing gap.
@fegin fegin requested a review from d4l3k January 29, 2025 18:19
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 29, 2025
@fegin fegin requested a review from H-Huang January 29, 2025 18:19
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like lint+doc is failing

@fegin fegin merged commit c3d5d54 into main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants