Skip to content

ci: use stable rust and gate on number of gpus #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2024
Merged

ci: use stable rust and gate on number of gpus #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/unittest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,17 @@ jobs:
gpu-arch-type: ${{ matrix.gpu-arch-type }}
gpu-arch-version: ${{ matrix.gpu-arch-version }}
script: |
set -ex

# install python and protobuf
conda create -n venv python=3.10 protobuf -y
conda activate venv
python -m pip install --upgrade pip

yum install -y rust cargo
# install recent version of Rust via rustup
curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain=stable --profile=default -y
. "$HOME/.cargo/env"

python -m pip install --upgrade pip
pip install -e .[dev] -v

pytest -v
Expand Down
4 changes: 2 additions & 2 deletions torchft/process_group_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ def test_dummy(self) -> None:
m = torch.nn.parallel.DistributedDataParallel(m, process_group=pg)
m(torch.rand(2, 3))

@skipUnless(torch.cuda.is_available(), "needs CUDA")
def test_baby_nccl(self) -> None:
@skipUnless(torch.cuda.device_count() >= 2, "need two CUDA devices")
def test_baby_nccl_2gpu(self) -> None:
store = TCPStore(
host_name="localhost", port=0, is_master=True, wait_for_workers=False
)
Expand Down
Loading