Skip to content

Add DiLoCo #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add DiLoCo #92

merged 1 commit into from
Jan 31, 2025

Conversation

@H-Huang
Copy link
Contributor

@H-Huang H-Huang commented Jan 30, 2025

This is merging #76 into main

Ghstack doesn't work to land PRs anymore: https://www.internalfb.com/phabricator/paste/view/P1722219368

@H-Huang
Add DiLoCo
3c12ce9 
ghstack-source-id: 357333e
Pull Request resolved: #76
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 30, 2025
@H-Huang H-Huang requested review from d4l3k and fegin January 30, 2025 23:53
d4l3k
d4l3k approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming same as other PR

@H-Huang H-Huang merged commit 2e2a3cb into main Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4l3k d4l3k d4l3k approved these changes

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @d4l3k @facebook-github-bot