Skip to content

examples,docs: adjust ddp example timeout and docs #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

examples,docs: adjust ddp example timeout and docs #93

merged 1 commit into from
Jan 31, 2025

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Jan 31, 2025

This updates timeouts for train_ddp.py so it recovers fast and some documentation to make it clearer what each option does.

Test plan:

torchft_lighthouse --min_replicas 2 --join_timeout_ms 10000
torchx run -- --replicas 10
  • killing workers via dashboard

@d4l3k d4l3k requested review from H-Huang, c-p-i-o and fegin January 31, 2025 19:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 31, 2025
H-Huang
H-Huang approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d4l3k d4l3k merged commit 6e5dcbd into main Jan 31, 2025
6 checks passed
@d4l3k d4l3k deleted the d4l3k/ddp_timeouts branch January 31, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@H-Huang H-Huang H-Huang approved these changes

+1 more reviewer

@c-p-i-o c-p-i-o c-p-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@d4l3k @fegin @c-p-i-o @H-Huang @facebook-github-bot