Skip to content

Refactor local_sgd integration tests #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

Refactor local_sgd integration tests #96

merged 1 commit into from
Feb 4, 2025

Conversation

@H-Huang
Copy link
Contributor

@H-Huang H-Huang commented Feb 4, 2025

Refactor PR to move local_sgd integration tests into a new file local_sgd_integ_test.py

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 4, 2025
@H-Huang H-Huang requested review from c-p-i-o, d4l3k and fegin February 4, 2025 19:58
d4l3k
d4l3k approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit 927f8b4 into meta-pytorch:main Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4l3k d4l3k d4l3k approved these changes

@fegin fegin Awaiting requested review from fegin

@c-p-i-o c-p-i-o Awaiting requested review from c-p-i-o

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@H-Huang @d4l3k @facebook-github-bot