Added unit test for Heuristic Storage Reservation #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: **Context:** Heuristic Storage reservation is a common component for all planner that checks if the given module along with the constraints can be sharded across the topology. **In this diff:** We added a UT to validate the error for storage use in the storage reservation process. If the given module is larger than the provided topology. We need to OOM the process asap with appropriate error to notify the PG Differential Revision: D85892579
meta-cla
bot
added
the
CLA Signed
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
Heuristic Storage reservation is a common component for all planner that checks if the given module along with the constraints can be sharded across the topology.
In this diff:
We added a UT to validate the error for storage use in the storage reservation process. If the given module is larger than the provided topology. We need to OOM the process asap with appropriate error to notify the PG
Differential Revision: D85892579