expose runner itself with context manager #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
daniel-ohayon
approved these changes
May 22, 2025
bobyangyf
force-pushed
the
export-D72677312
branch
from
4639dc0 to
89c09da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
May 28, 2025
Summary: Pull Request resolved: meta-pytorch#1069 Reviewed By: lgarg26, kiukchung Differential Revision: D72677312
bobyangyf
force-pushed
the
export-D72677312
branch
from
89c09da to
93dd024
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: meta-pytorch#1069 Reviewed By: lgarg26, kiukchung Differential Revision: D72677312
bobyangyf
force-pushed
the
export-D72677312
branch
from
93dd024 to
fa6cbd3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: meta-pytorch#1069 Reviewed By: lgarg26, kiukchung Differential Revision: D72677312
bobyangyf
force-pushed
the
export-D72677312
branch
from
fa6cbd3 to
7ed4b89
Compare
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: meta-pytorch#1069 Reviewed By: lgarg26, kiukchung Differential Revision: D72677312
bobyangyf
force-pushed
the
export-D72677312
branch
from
7ed4b89 to
8f281e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
|
@bobyangyf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bobyangyf
changed the title
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 6, 2025
Summary: Right now, when we `enter` context after `get_fb_runner`, we are using the existing definition in `Runner` which causes type erasure to the super type `Runner`. While this is fine for most cases, we lose the ability to access the apis in sub classes. Here, we expose the self type instead to prevent erasing types Reviewed By: kiukchung Differential Revision: D72677312 Pulled By: bobyangyf
bobyangyf
force-pushed
the
export-D72677312
branch
from
8f281e4 to
5b68610
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 9, 2025
Summary: Right now, when we `enter` context after `get_fb_runner`, we are using the existing definition in `Runner` which causes type erasure to the super type `Runner`. While this is fine for most cases, we lose the ability to access the apis in sub classes. Here, we expose the self type instead to prevent erasing types Reviewed By: kiukchung Differential Revision: D72677312 Pulled By: bobyangyf
bobyangyf
force-pushed
the
export-D72677312
branch
from
5b68610 to
325337f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
bobyangyf
added a commit
to bobyangyf/torchx
that referenced
this pull request
Jun 9, 2025
Summary: Right now, when we `enter` context after `get_fb_runner`, we are using the existing definition in `Runner` which causes type erasure to the super type `Runner`. While this is fine for most cases, we lose the ability to access the apis in sub classes. Here, we expose the self type instead to prevent erasing types Reviewed By: kiukchung Differential Revision: D72677312 Pulled By: bobyangyf
bobyangyf
force-pushed
the
export-D72677312
branch
from
325337f to
381edd8
Compare
Summary: Right now, when we `enter` context after `get_fb_runner`, we are using the existing definition in `Runner` which causes type erasure to the super type `Runner`. While this is fine for most cases, we lose the ability to access the apis in sub classes. Here, we expose the self type instead to prevent erasing types Reviewed By: kiukchung Differential Revision: D72677312 Pulled By: bobyangyf
bobyangyf
force-pushed
the
export-D72677312
branch
from
381edd8 to
1c91330
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72677312 |
|
@bobyangyf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
merged commit 50b8c02
into
meta-pytorch:main
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now, when we
entercontext afterget_fb_runner, we are using the existing definition inRunnerwhich causes type erasure to the super typeRunner.While this is fine for most cases, we lose the ability to access the apis in sub classes.
Here, we expose the self type instead to prevent erasing types
Reviewed By: kiukchung
Differential Revision: D72677312