Version based GPU configuration and QoS addition #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78778304 |
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 23, 2025
Summary: Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Differential Revision: D78778304
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
2 times, most recently
from
f67d4b6 to
d06b519
Compare
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 23, 2025
Summary: Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Differential Revision: D78778304
|
This pull request was exported from Phabricator. Differential Revision: D78778304 |
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
from
d06b519 to
9a36468
Compare
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: meta-pytorch#1092 Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Differential Revision: D78778304
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
from
9a36468 to
899defb
Compare
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 28, 2025
Summary: Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Reviewed By: kiukchung Differential Revision: D78778304
|
This pull request was exported from Phabricator. Differential Revision: D78778304 |
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 28, 2025
Summary: Pull Request resolved: meta-pytorch#1092 Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Reviewed By: kiukchung Differential Revision: D78778304
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
from
899defb to
e28eb0f
Compare
kvenkateshan-meta
added a commit
to kvenkateshan-meta/torchx
that referenced
this pull request
Jul 29, 2025
Summary: Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Reviewed By: kiukchung Differential Revision: D78778304
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
from
e28eb0f to
fb9e308
Compare
Summary: Pull Request resolved: meta-pytorch#1092 Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call `gpus-per-node` in sbatch to ensure failure free allocation. https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md # Changes here 1. Introduced Slurm Version based GPU request configuration 2. Introduced an option QoS parameter which can be used to control priority of jobs. Reviewed By: kiukchung Differential Revision: D78778304
kvenkateshan-meta
force-pushed
the
export-D78778304
branch
from
fb9e308 to
942aa7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78778304 |
kiukchung
approved these changes
Jul 29, 2025
facebook-github-bot
merged commit ae55901
into
meta-pytorch:main
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Slurm 24.11.0rc1 and beyond do not suport GRES per task. So we need to call
gpus-per-nodein sbatch to ensure failure free allocation.https://github.com/SchedMD/slurm/blob/master/CHANGELOG/slurm-24.11.md
Changes here
Introduced Slurm Version based GPU request configuration
Introduced an option QoS parameter which can be used to control priority of jobs.
Differential Revision: D78778304