Remove experimental hot spare policy #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61746435 |
Summary: Pull Request resolved: meta-pytorch#948 This diff removes the experimental hot spare restart policy and uses role restart instead with quorum hosts set to the min nodes requirement. This isnt the best as this gives us no good way to differentiate between elasticity and quorum based restarts in the future but we can address this by supporting quorum restarts differently in the future. Differential Revision: D61746435
|
This pull request was exported from Phabricator. Differential Revision: D61746435 |
manav-a
force-pushed
the
export-D61746435
branch
from
79cee9d to
352da37
Compare
manav-a
changed the title
kunalb
approved these changes
Aug 26, 2024
facebook-github-bot
merged commit 69129eb
into
meta-pytorch:main
20 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D61746435