fix: lowercase ident #397
Open
fix: lowercase ident #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `ident` contains a string with upper and lower case letters. When saving in Picard, this causes everything in the resulting tag to be converted to lower case. The next time the album or track is refreshed, a difference is now detected because the plugin returns upper and lower case. Picard compares with the existing tag, which is only written in lower case. The result is that the lower case tag is deleted and replaced with a mixed case tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
identcontains a string with upper and lower case letters. When saving in Picard, this causes everything in the resulting tag to be converted to lower case. The next time the album or track is refreshed, a difference is now detected because the plugin returns upper and lower case. Picard compares with the existing tag, which is only written in lower case. The result is that the lower case tag is deleted and replaced with a mixed case tag.