Skip to content

Commit 3050507

Browse files
committed
Try node 386.
1 parent 768eae4 commit 3050507

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

source/metacall.scm

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,25 +78,33 @@
7878
)
7979

8080
; NodeJS Loader Dependencies
81-
82-
; TODO: Try with version 20
83-
(define-public node-20
81+
(define-public node-lts-386
8482
(package/inherit node-lts
85-
(name "node-20")
83+
(name "node-lts-386")
8684
(arguments
8785
(substitute-keyword-arguments (package-arguments node-lts)
8886
((#:phases phases '%standard-phases)
8987
`(modify-phases ,phases
90-
(delete 'check))))))) ; Tests in 386 architecture fail on upstream
91-
92-
(define-public libnode-20
88+
(add-before 'delete-problematic-tests 'delete-problematic-tests-386
89+
(lambda* (#:key inputs #:allow-other-keys)
90+
;; FIXME: These tests fail in 386
91+
(for-each delete-file
92+
'("test/parallel/test-fs-utimes-y2K38.js"
93+
"test/abort/test-zlib-invalid-internals-usage.js"))))))))))
94+
95+
(define-public libnode-386
9396
(package/inherit libnode
94-
(name "libnode-20")
97+
(name "libnode-386")
9598
(arguments
9699
(substitute-keyword-arguments (package-arguments libnode)
97100
((#:phases phases '%standard-phases)
98101
`(modify-phases ,phases
99-
(delete 'check))))))) ; Tests in 386 architecture fail on upstream
102+
(add-before 'delete-problematic-tests 'delete-problematic-tests-386
103+
(lambda* (#:key inputs #:allow-other-keys)
104+
;; FIXME: These tests fail in 386
105+
(for-each delete-file
106+
'("test/parallel/test-fs-utimes-y2K38.js"
107+
"test/abort/test-zlib-invalid-internals-usage.js"))))))))))
100108

101109
(define-public espree
102110
(package
@@ -445,8 +453,8 @@ for any host, on any OS. TypeScript compiles to readable, standards-based JavaSc
445453
`(
446454
("python" ,python-3) ; Python Loader dependency
447455
("ruby" ,ruby-2.7) ; Ruby Loader dependency
448-
("node" ,node-20) ; NodeJS Loader dependency
449-
("libnode" ,libnode-20) ; NodeJS Loader dependency
456+
("node" ,node-lts-386) ; NodeJS Loader dependency
457+
("libnode" ,libnode-386) ; NodeJS Loader dependency
450458
("libuv" ,libuv) ; NodeJS Loader dependency
451459
("espree" ,espree) ; NodeJS Loader dependency
452460
("typescript" ,typescript) ; TypeScript Loader dependency

0 commit comments

Comments
 (0)