Allow specifying an initial firewall ruleset.#64
Draft
Conversation
This is handy for the capi-provider.
Getting methods are non pointers, mutating ones are pointers. This is fine and expected.
…nitial-firewall-ruleset
…n' into initial-firewall-ruleset
Contributor
|
Also includes #66 |
This was referenced Mar 12, 2025
vknabel
reviewed
Dec 11, 2025
Comment on lines
+170
to
+175
| if r.Target.Annotations != nil { | ||
| if val, ok := r.Target.Annotations[v2.FirewallNoControllerConnectionAnnotation]; ok { | ||
| set.Annotations[v2.FirewallNoControllerConnectionAnnotation] = val | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This could probably be an extra PR
vknabel
reviewed
Dec 11, 2025
| shootTokenSecret string | ||
| shootTokenPath string | ||
| sshKeySecret string | ||
| sshKeySecretNamespace string |
vknabel
added a commit
that referenced
this pull request
Dec 11, 2025
Merged
vknabel
reviewed
Dec 11, 2025
Comment on lines
+160
to
+168
| if r.Target.Annotations != nil { | ||
| if val, ok := r.Target.Annotations[v2.FirewallNoControllerConnectionAnnotation]; ok { | ||
| if meta.Annotations == nil { | ||
| meta.Annotations = map[string]string{} | ||
| } | ||
| meta.Annotations[v2.FirewallNoControllerConnectionAnnotation] = val | ||
| } | ||
| } | ||
|
|
vknabel
added a commit
that referenced
this pull request
Dec 11, 2025
vknabel
added
area: cluster-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is handy for the capi-provider.