-
Couldn't load subscription status.
- Fork 54
initial core cm cli docs #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by CodeRabbitDocumentation
WalkthroughAdds a new “Candy Machine Commands” subsection to the CLI navigation and a complete set of Candy Machine CLI documentation pages (overview and commands: create, upload, insert, validate, fetch, withdraw). Updates CLI index and core candy machine docs to include CLI quick-links and references; minor installation header cleanup. Changes
Sequence Diagram(s)Skipped — changes are documentation and navigation updates only; no control-flow modifications to diagram. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Files/areas to spot-check:
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)src/pages/**/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 12
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/core-candy-machine/create.md (1)
107-141: Remove JavaScript-style comments from JSON example.
cm-config.jsonmust be valid JSON; the example includes//comments on Lines 111 and 118 that would cause the CLI to reject the file if copied verbatim. Please move those notes into surrounding prose or replace them with placeholders inside strings so the snippet remains valid JSON.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (12)
src/components/products/cli/index.js(1 hunks)src/pages/cli/cm/create.md(1 hunks)src/pages/cli/cm/fetch.md(1 hunks)src/pages/cli/cm/index.md(1 hunks)src/pages/cli/cm/insert.md(1 hunks)src/pages/cli/cm/upload.md(1 hunks)src/pages/cli/cm/validate.md(1 hunks)src/pages/cli/cm/withdraw.md(1 hunks)src/pages/cli/index.md(4 hunks)src/pages/core-candy-machine/create.md(1 hunks)src/pages/core-candy-machine/index.md(1 hunks)src/pages/core-candy-machine/insert-items.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
src/pages/**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
Markdoc processes
.mdfiles in pages directory
Files:
src/pages/core-candy-machine/create.mdsrc/pages/cli/cm/insert.mdsrc/pages/cli/cm/fetch.mdsrc/pages/cli/cm/create.mdsrc/pages/core-candy-machine/insert-items.mdsrc/pages/cli/cm/validate.mdsrc/pages/core-candy-machine/index.mdsrc/pages/cli/cm/withdraw.mdsrc/pages/cli/cm/index.mdsrc/pages/cli/cm/upload.mdsrc/pages/cli/index.md
src/components/products/*/index.js
📄 CodeRabbit inference engine (CLAUDE.md)
Each product has its own configuration in
src/components/products/[product]/index.jsthat defines navigation structure, hero components, section organization, GitHub links, and styling themes
Files:
src/components/products/cli/index.js
src/components/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Custom components go in
src/components/
Files:
src/components/products/cli/index.js
🪛 markdownlint-cli2 (0.18.1)
src/pages/cli/cm/insert.md
16-16: Bare URL used
(MD034, no-bare-urls)
18-18: Bare URL used
(MD034, no-bare-urls)
src/pages/cli/cm/fetch.md
22-22: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
25-25: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
29-29: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
src/pages/cli/cm/create.md
22-22: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
25-25: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
29-29: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
35-35: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
37-37: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
48-48: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
86-86: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
181-181: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
182-182: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
197-197: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
198-198: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
236-236: Files should end with a single newline character
(MD047, single-trailing-newline)
src/pages/cli/cm/validate.md
22-22: Trailing spaces
Expected: 0 or 2; Actual: 3
(MD009, no-trailing-spaces)
36-36: Files should end with a single newline character
(MD047, single-trailing-newline)
src/pages/cli/cm/index.md
32-32: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
38-38: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
44-44: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
111-111: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
112-112: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
127-127: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
128-128: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
178-178: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
184-184: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
191-191: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
198-198: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
217-217: Files should end with a single newline character
(MD047, single-trailing-newline)
src/pages/cli/cm/upload.md
40-40: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
44-44: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
87-87: Files should end with a single newline character
(MD047, single-trailing-newline)
src/pages/cli/index.md
18-18: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
88-88: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
100-100: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🔇 Additional comments (4)
src/components/products/cli/index.js (1)
74-106: LGTM! Navigation structure is well-organized.The new "Candy Machine Commands" section follows the established navigation patterns and provides clear, descriptive titles for all command pages. The routing structure is consistent with other CLI sections.
src/pages/cli/index.md (3)
18-23: LGTM! Candy Machine Support section is well-written.The new subsection provides a clear, concise overview of Candy Machine capabilities and aligns well with the new dedicated documentation pages.
51-51: LGTM! Good generalization of the Getting Started section.Changing from "Start using the core commands" to "Start using the commands" better reflects the broader scope of the CLI now that Candy Machine commands are included.
83-106: LGTM! Quick Start Examples provide helpful entry points.The examples clearly demonstrate both the Candy Machine wizard workflow and individual asset creation, giving users concrete starting points.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (4)
src/pages/cli/cm/withdraw.md (2)
10-10: Fix grammar: use “cannot”.Line 10 still reads “can not,” which is incorrect in formal documentation; replace it with “cannot.”
27-27: Align--forcewarning with house style.Inline “Danger” is inconsistent with our warning pattern. Reformat the flag description (e.g., use a warning callout or bold “Danger:” label, or adopt the
⚠️ emoji style used elsewhere) for consistency.src/pages/cli/cm/index.md (2)
17-17: Break up the run-on sentence in Quick Start.Line 17 is still a long clause chain; convert it to a short lead-in plus a bulleted list (asset validation, upload, creation with guards, insertion with tracking) for readability.
198-198: State explicitly thatcollection.jsonmust contain a requiredname.Clarify that the
namefield is mandatory by replacing “valid" with “required” (e.g., “Include collection.json with a requirednamefield”).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
src/pages/cli/cm/create.md(1 hunks)src/pages/cli/cm/fetch.md(1 hunks)src/pages/cli/cm/index.md(1 hunks)src/pages/cli/cm/insert.md(1 hunks)src/pages/cli/cm/upload.md(1 hunks)src/pages/cli/cm/validate.md(1 hunks)src/pages/cli/cm/withdraw.md(1 hunks)src/pages/cli/installation.md(0 hunks)
💤 Files with no reviewable changes (1)
- src/pages/cli/installation.md
🧰 Additional context used
📓 Path-based instructions (1)
src/pages/**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
Markdoc processes
.mdfiles in pages directory
Files:
src/pages/cli/cm/create.mdsrc/pages/cli/cm/insert.mdsrc/pages/cli/cm/validate.mdsrc/pages/cli/cm/index.mdsrc/pages/cli/cm/withdraw.mdsrc/pages/cli/cm/fetch.mdsrc/pages/cli/cm/upload.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks! :)
Changes:
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/create
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/upload
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/insert
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/validate
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/fetch
https://developer-hub-git-cli-cm-metaplex-foundation.vercel.app/cli/cm/withdraw