perf: use true private variables in code example#59
Open
GeorgianStan wants to merge 1 commit intomgechev:masterfrom
Open
perf: use true private variables in code example#59GeorgianStan wants to merge 1 commit intomgechev:masterfrom
GeorgianStan wants to merge 1 commit intomgechev:masterfrom
Conversation
The TS access modifier `private` is removed in detriment of true private variables. Use the same code for `PointAnimationComponent` class to fix wrong variable names that were used when the document was translated for other languages.
Author
|
Hi @mgechev. Did you have time to review the PR? |
|
#include <Joystick.h> // Create the Joystick // Constant that maps the physical pin to the joystick button. void setup() { } // Last state of the button void loop() { } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TS access modifier
privateis removed in detriment of true privatevariables.
Use the same code for
PointAnimationComponentclass to fix wrongvariable names that were used when the document was translated for
other languages.