Remove RevisionableStorageInterfaceStubTest#942
Merged
Conversation
PHPStan 2.1.38+ reworked phpDoc inheritance to resolve through reflection instead of re-walking the hierarchy (phpstan/phpstan-src#4829). This causes @deprecated annotations on EntityStorageInterface::loadRevision to propagate through the full class/interface hierarchy, bypassing the RevisionableStorageInterface stub that was supposed to suppress false positives. The test no longer validates the stub's intended behavior, so remove it and the associated data fixture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mglaman
deleted the
fix/941-remove-revisionable-storage-interface-stub-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RevisionableStorageInterfaceStubTestand its data fixturebug-586.php@deprecatedonEntityStorageInterface::loadRevisionto propagate through the full class/interface hierarchyRevisionableStorageInterfacestub no longer suppresses the false positive deprecation warnings it was designed to prevent, so the test no longer validates meaningful behaviorFixes #941
Test plan
php vendor/bin/phpunit)^10.4🤖 Generated with Claude Code