-
Notifications
You must be signed in to change notification settings - Fork 78
Add shell completion for mkdwarfs (bash, zsh) #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this! In fact, I was thinking about adding completions for the last release and then abandoned the idea because it seemed too involved.
My main concern is that some of the option arguments can get quite complex, especially those that can be defined per category. But I'm happy to start with something that works well enough to be useful and then improve that over time.
45c1a35
to
60103cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just two minor comments. I'll try to play around with the completions myself in the next few days (I'm currently on vacation).
I've been playing with the |
- Basic completion for common shells for mkdwarfs command. - Installed only when WITH_TOOLS=ON and NOT WIN32. - Potentially other commands could be added, but mkdwarfs is the most complicated of them. - It's not perfect completion and could use some improvements to "compression" options that allow a sophisticated syntax including category/algo/algo_options.
60103cd
to
b75bcd9
Compare
Quick summary:
|
This is a basic completion for mkdwarfs for the two popular shells. Will be included as part of the debian package, but probably more useful here upstream.
Some common locations to store (doc/completion) and install (CMakeLists.txt) those selected, but happy to move them around or fixup cmake differently. CMake is globbed in 2 dirs to allow future completions to be added/installed as-is.
Also since it's written for debian, I used MIT in there and later realised mkdwarfs is a "writing" application. For the upstream version here, happy to flip that around if you would adopt it.