- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
          GeoLocationNameValue with examples
          #2308
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0b0a1e2
              4ade9f1
              64a323e
              8cc2b2e
              d7116b5
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| has_raw_value: "USA: Maryland: Bethesda" | ||
| subnational_1_or_ocean_region: Maryland | ||
| locality: Bethesda | ||
| type: nmdc:GeoLocationNameValue | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| country_or_sea: USA | ||
| subnational_1_or_ocean_region: Maryland | ||
| locality: Bethesda | ||
| type: nmdc:GeoLocationNameValue | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| has_raw_value: "USA: Maryland: Bethesda" | ||
| country_or_sea: USA | ||
| subnational_1_or_ocean_region: Maryland | ||
| locality: Bethesda | ||
| type: nmdc:GeoLocationNameValue | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| has_raw_value: "USA: Bethesda, Maryland" | ||
| country_or_sea: USA | ||
| subnational_1_or_ocean_region: Maryland | ||
| locality: Bethesda | ||
| type: nmdc:GeoLocationNameValue | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| has_raw_value: "Atlantic Ocean: Charlie Gibbs Fracture Zone" | ||
| country_or_sea: Atlantic Ocean | ||
| subnational_1_or_ocean_region: Charlie Gibbs Fracture Zone | ||
| type: nmdc:GeoLocationNameValue | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -22,6 +22,56 @@ default_range: string | |
|  | ||
| slots: | ||
|  | ||
| country_or_sea: | ||
| range: string | ||
| description: A maximally coarse-grained, geo-political description of where something is, came from, took place, etc. | ||
| comments: | ||
| - MIxS states that country or sea names should be chosen from the INSDC country list aka the geo_loc_name-qualifier-vocabulary | ||
| - https://www.insdc.org/submitting-standards/geo_loc_name-qualifier-vocabulary/ | ||
| - https://www.cia.gov/the-world-factbook/ and http://unstats.un.org/unsd/methods/m49/m49.htm | ||
| todos: | ||
| - "ValueError: https://www.cia.gov/the-world-factbook/ and http://unstats.un.org/unsd/methods/m49/m49.htm is not a valid URI or CURIE" | ||
| - when populating see_also | ||
| examples: | ||
| - value: "Canada" | ||
| - value: "Atlantic Ocean" | ||
| - value: "USA" | ||
| narrow_mappings: | ||
| - mixs:0000010 | ||
| rank: 1 | ||
| required: true | ||
|  | ||
| subnational_1_or_ocean_region: | ||
| range: string | ||
| description: A geo-political description of a region that is a direct, unambiguous subdivision of a paired country_or_sea value, | ||
| OR an unambiguous region or feature within an ocean or "sea". | ||
| 
      Comment on lines
    
      +46
     to 
      +47
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @turbomam, it's not clear to me what the two operands of the  Interpretation 1 (I added EITHER to mark the first operand): 
 Interpretation 2 (I added "EITHER" to mark the first operand): 
 
      Comment on lines
    
      +46
     to 
      +47
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few lines above this, we have the word  
 I don't know why it is enclosed in quotes here. 
 | ||
| comments: | ||
| - "INSDC's guidance could be taken to imply that Vancouver or Cote d’Azur are appropriate values for this slot, but NMDC would place those in the locality slot." | ||
| aliases: | ||
| - state | ||
| examples: | ||
| - value: "British Columbia" | ||
| - value: "Charlie Gibbs Fracture Zone" | ||
| - value: "Maryland" | ||
| narrow_mappings: | ||
| - mixs:0000010 | ||
| rank: 2 | ||
| recommended: true | ||
|  | ||
| locality: | ||
| range: string | ||
| description: A geo-political description of a region or feature that is within or overlaps with a paired subnational_1_or_ocean_region value. | ||
| aliases: | ||
| - state | ||
| examples: | ||
| - value: "Vancouver" | ||
| - value: "Cote d’Azur" | ||
| - value: "Bethesda" | ||
| narrow_mappings: | ||
| - mixs:0000010 | ||
| rank: 3 | ||
| recommended: true | ||
|  | ||
| qc_comment: | ||
| range: string | ||
| description: >- | ||
|  | @@ -598,27 +648,27 @@ enums: | |
|  | ||
| Virus Summary: | ||
| description: Tab separated file listing the viruses found by geNomad. | ||
| see_also: | ||
| see_also: | ||
| - https://portal.nersc.gov/genomad/ | ||
| annotations: | ||
| file_name_pattern: '^_virus_summary\.tsv?$' | ||
|  | ||
| Plasmid Summary: | ||
| description: Tab separated file listing the plasmids found be geNomad. | ||
| see_also: | ||
| see_also: | ||
| - https://portal.nersc.gov/genomad/ | ||
| annotations: | ||
| file_name_pattern: '^_plasmid_summary\.tsv?$' | ||
|  | ||
| GeNomad Aggregated Classification: | ||
| description: >- | ||
| Tab separated file which combines the results from neural network-based classification | ||
| and marker-based classification for virus and plasmid detection with geNomad. | ||
| see_also: | ||
| see_also: | ||
| - https://portal.nersc.gov/genomad/ | ||
| annotations: | ||
| file_name_pattern: '^_aggregated_classification\.tsv?$' | ||
| file_name_pattern: '^_aggregated_classification\.tsv?$' | ||
|  | ||
| Reference Calibration File: | ||
| description: A file that contains data used to calibrate a natural organic matter or metabalomics analysis. | ||
|  | ||
|  | @@ -1090,12 +1140,12 @@ enums: | |
| title: Metagenome | ||
| metatranscriptome: | ||
| aliases: | ||
| - metaT | ||
| - metaT | ||
| title: Metatranscriptome | ||
| amplicon_sequencing_assay: | ||
| meaning: OBI:0002767 | ||
| title: Amplicon | ||
|  | ||
| MassSpectrometryEnum: | ||
| permissible_values: | ||
| metaproteome: | ||
|  | @@ -1106,13 +1156,13 @@ enums: | |
| aliases: | ||
| - metaB | ||
| title: Metabolome | ||
| lipidome: | ||
| lipidome: | ||
| title: Lipidome | ||
| nom: | ||
| aliases: | ||
| - natural organic matter | ||
| title: Natural Organic Matter | ||
|  | ||
| ExtractionTargetEnum: | ||
| permissible_values: | ||
| DNA: { } | ||
|  | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR (I'm commenting on it while it's in my attention): I don't understand this sentence.