Start improving slots that had units excuses #2690
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_purity and concentration abstract
- Add storage_units annotation to exp_pipe slot (unitless: "1")
- Add storage_units annotation to occup_density_samp slot ("1/[sft_i]")
- Add "1/[sft_i]" (per square foot) unit to UnitEnum in attribute_values.yaml
- Make biomaterial_purity slot abstract (requires migrator for dna_absorb1/dna_absorb2)
- Make concentration slot abstract with comment documenting union of child units (requires migrator for source_concentration/final_concentration)
- Update test_units_alignment.py to enforce that abstract QuantityValue slots must NOT have storage_units or units_alignment_excuse annotations
Addresses #2687
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
|
|
@pkalita-lbl @eecavanna I'm going to need some help with this PR I can break it up into multiple single topic PRs if necessary
|
|
I definitely support switching from |
I'm not aware of any migration-related tests that connect to MongoDB. Here's a list of the migration-related tests I want to continue to be run as part of the automated test suite:
|
turbomam
commented
Oct 22, 2025
|
|
||
| test-python: | ||
| $(RUN) python -m unittest discover | ||
| $(RUN) pytest |
There was a problem hiding this comment.
make sure its a dev dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2687
🤖 Generated with Claude Code