-
Couldn't load subscription status.
- Fork 9
Add slot to WorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution
#2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
I'd like to discuss DataObjects referring to a newer WorkflowExecution instead of or in addition to individual DataObjects over time mostly because workflow outputs can change over time there may not be 1:1 of the replacement files and or may involve increasingly complicated logic whereas the WorkflowExecution subclasses are more stable over time. Tagging @eecavanna and @shreddd because this will need to be coordinated with corresponding changes to referential integrity checks in nmdc-runtime. If there is a newer version and something goes wrong and that version needs to be deleted the reference to that needs to be removed. |
This comment was marked as resolved.
This comment was marked as resolved.
WorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution and DataObjectWorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution
|
@aclum Now this slot only references the newer WorkflowExecution that makes the records "outdated". I think this is much cleaner and more maintainable, thanks for the feedback. |
|
Looks great |
This PR
superseded_byto the schemasuperseded_bytoWorkflowExecutionandDataObjectclassessuperseded_byto the specific type ofWorkflowExecutionsubclassWorkflowExecutionandDataObjectclasses to point to newer versions of associated WorkflowExecution and DataObject #2693