Skip to content

Conversation

@kheal
Copy link
Contributor

@kheal kheal commented Oct 21, 2025

This PR

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2695/

Built to branch gh-pages at 2025-10-24 19:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@kheal kheal requested review from aclum and turbomam October 21, 2025 22:46
@kheal kheal marked this pull request as ready for review October 21, 2025 22:51
@kheal kheal self-assigned this Oct 21, 2025
@aclum
Copy link
Contributor

aclum commented Oct 22, 2025

I'd like to discuss DataObjects referring to a newer WorkflowExecution instead of or in addition to individual DataObjects over time mostly because workflow outputs can change over time there may not be 1:1 of the replacement files and or may involve increasingly complicated logic whereas the WorkflowExecution subclasses are more stable over time.

Tagging @eecavanna and @shreddd because this will need to be coordinated with corresponding changes to referential integrity checks in nmdc-runtime. If there is a newer version and something goes wrong and that version needs to be deleted the reference to that needs to be removed.

@kheal

This comment was marked as resolved.

@kheal kheal marked this pull request as draft October 22, 2025 20:15
@kheal kheal changed the title Add slot to WorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution and DataObject Add slot to WorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution Oct 24, 2025
@kheal
Copy link
Contributor Author

kheal commented Oct 24, 2025

@aclum Now this slot only references the newer WorkflowExecution that makes the records "outdated". I think this is much cleaner and more maintainable, thanks for the feedback.

@kheal kheal marked this pull request as ready for review October 24, 2025 19:07
@aclum
Copy link
Contributor

aclum commented Oct 24, 2025

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add slot to WorkflowExecution and DataObject classes to point to newer versions of associated WorkflowExecution and DataObject

3 participants