Add orbitrap_exploris_120 as permissible value to InstrumentModelEnum
#2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Do you want to be more specific here? MassIVE says Orbitrap Exploris 120 which does have an exact mapping to the MS ontology? https://www.ebi.ac.uk/ols4/ontologies/ms/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FMS_1003095?lang=en For the sequencing instrument permissible values I've done both, have a more generic permissive value for when the series information isn't known plus PVs for where it is (e.g., hiseq, hiseq_2000, etc) |
|
@aclum good call, metadata on the raw files says it's from the 120 I'll update. |
kheal
changed the title
orbitrap_exploris as permissible value to InstrumentModelEnumorbitrap_exploris_120 as permissible value to InstrumentModelEnum
aclum
approved these changes
Oct 23, 2025
|
FYI @turbomam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
orbitrap_exploris_120as permissible value toInstrumentModelEnum, which is needed for the EcoFab LCMS Metabolomics data. Closes #2699