-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Vending: Added PI access management #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Why not just rename the SafetyNet option to Play Integrity and merge all code together? Also the base SafetyNet is dead, the remaining code is probably just used as part of Play Integrity. |
|
SafetyNet, Play Integrity and ReCaptcha Enterprise all share the use of DroidGuard. The current "Allow device attestation" toggle in the SafetyNet section already controls DroidGuard (and thus effectively Play Integrity). Best forward would be to:
Having a dedicated Play Integrity is indeed confusing. |
|
Thanks for the reminder, which made me confirm my previous modification plan. |
|
Only add extra code to the existing code; whether or not to delete previous code is determined by mar-v-in. |
|
@mar-v-in |
|
NOTE: Even if the "proxy" code is NOT perfectly valid, as long as the app believe it it is fine. |
|
@ale5000-git that's not possible, the format of those two are different and we can't migrate them as they're signed cryptographically. |
|
@mar-v-in |
|
I don't think they even use the same signing key, so that wouldn't work either. Apps that use SafetyNet are dead, I don't think it's worth the effort for us to try getting a few of them running that have a terribly broken implementations. |
|
@mar-v-in
(maybe also keep documentation of the previous behaviour as code comments; remember that Google change their mind pretty fast) |
|
For bank apps the user may have to use an old version because the new version removed support for some Android versions; and the app may still work (with a warning displayed to the user) even if SafetyNet fails but if the code is removed completely then the app may crash. |
New: