This repository was archived by the owner on Oct 20, 2023. It is now read-only.
Open
Conversation
list of IPs bypassing authentication entirely.. There is something messed up with windows 10 explorer.exe authentication ( see micromata#47 ), this patch allows mounting from windows 10 with some security (essentially a ip whitelist) haven't implemented any tests for it though.
Collaborator
|
Hej, |
chclaus
suggested changes
Aug 20, 2023
Collaborator
chclaus
left a comment
chclaus
left a comment
There was a problem hiding this comment.
Hej, thank a lot!
Your code looks good to me. But I think we need a unit test for all ways of authentication. It's a critical part of the application. Do you have the possibility to add a test? I think you could extend the args struct in TestAuthenticate with the requestIpAddress.
Then you could add further szenarios like
{
"without credentials and incorrect ip address",
args{
config: &Config{Authentication_Bypass_IP_Addresses: []string{"127.0.0.1"}},
requestIpAddress: "192.168.0.1",
},
&AuthInfo{Username: "", Authenticated: false},
true,
},@samhocevar do you have any further ideas?
Greets and thanks again for the contribution. 👋 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list of IPs bypassing authentication entirely..
There is something messed up with windows 10 explorer.exe authentication ( see #47 ), this patch allows mounting from windows 10 with some security (essentially a ip whitelist)
haven't implemented any tests for it though.