Skip to content

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request makes several updates to the Key Vault configuration in the Bicep templates and JSON files, focusing on enabling soft delete, modifying retention policies, and removing purge protection. Additionally, it updates the Bicep compiler version and adjusts metadata. Below is a summary of the key changes:

Key Vault Configuration Updates:

  • Changed the enableSoftDelete parameter default value to true and updated the retention period for soft delete to 7 days instead of 30 days in infra/bicep/deploy_keyvault.bicep and infra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL32-R42), [[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1048-R1048))
  • Removed the enablePurgeProtection parameter and its associated logic from infra/bicep/deploy_keyvault.bicep and infra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL32-R42), [[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1032-L1038), [[3]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1169))

Module and Resource Configuration:

  • Updated the module keyvaultModule in infra/bicep/main.bicep to pass enableSoftDelete: true to the Key Vault deployment. ([infra/bicep/main.bicepL106-R106](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-6d5bbaf49aff20fcd5df30e6b6780f53182fdf8f71e8c25950e24d94d50e2612L106-R106))
  • Removed the enablePurgeProtection property from the Key Vault resource definition in infra/bicep/deploy_keyvault.bicep and infra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL120), [[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1169))

Metadata and Compiler Updates:

  • Upgraded the Bicep compiler version from 0.33.93.31351 to 0.36.1.42791 and updated the associated template hashes in infra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L7-R8), [[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L284-R285), [[3]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L378-R379), [[4]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L533-R534), [[5]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L707-R708), [[6]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L837-R838), [[7]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L969-R970), [[8]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1431-R1424), [[9]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1520-R1513), [[10]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1736-R1729))

Minor Text Adjustments:

  • Fixed newline formatting in the AzureOpenAISystemMessage parameter value in infra/bicep/main.json for better readability. ([infra/bicep/main.jsonL1670-R1662](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1670-R1662))

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 0021bc4 into byoc-researcher Jun 25, 2025
5 checks passed
@Harsh-Microsoft Harsh-Microsoft deleted the keyvault-fix branch July 16, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants