fix: researcher - enabling soft delete and removing purge protection for key vault #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several updates to the Key Vault configuration in the Bicep templates and JSON files, focusing on enabling soft delete, modifying retention policies, and removing purge protection. Additionally, it updates the Bicep compiler version and adjusts metadata. Below is a summary of the key changes:
Key Vault Configuration Updates:
enableSoftDeleteparameter default value totrueand updated the retention period for soft delete to 7 days instead of 30 days ininfra/bicep/deploy_keyvault.bicepandinfra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL32-R42),[[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1048-R1048))enablePurgeProtectionparameter and its associated logic frominfra/bicep/deploy_keyvault.bicepandinfra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL32-R42),[[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1032-L1038),[[3]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1169))Module and Resource Configuration:
module keyvaultModuleininfra/bicep/main.bicepto passenableSoftDelete: trueto the Key Vault deployment. ([infra/bicep/main.bicepL106-R106](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-6d5bbaf49aff20fcd5df30e6b6780f53182fdf8f71e8c25950e24d94d50e2612L106-R106))enablePurgeProtectionproperty from the Key Vault resource definition ininfra/bicep/deploy_keyvault.bicepandinfra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-62e03f5aa97a09f01ea1acc8ad346eb5d59a3ef4947759dd21e0f0c3d2fbc2eaL120),[[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1169))Metadata and Compiler Updates:
0.33.93.31351to0.36.1.42791and updated the associated template hashes ininfra/bicep/main.json. ([[1]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L7-R8),[[2]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L284-R285),[[3]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L378-R379),[[4]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L533-R534),[[5]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L707-R708),[[6]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L837-R838),[[7]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L969-R970),[[8]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1431-R1424),[[9]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1520-R1513),[[10]](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1736-R1729))Minor Text Adjustments:
AzureOpenAISystemMessageparameter value ininfra/bicep/main.jsonfor better readability. ([infra/bicep/main.jsonL1670-R1662](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/576/files#diff-a9c0ff862c2ddf7d893af29e946199ace2a134f3d51fa3071e6e35a7b0b6c0b2L1670-R1662))Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information