fix: Return consistent response for 'what is the asset value' query. #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to asset value query instructions, adds a new
createdByparameter for resource tagging, and makes a minor documentation correction. The changes enhance clarity and traceability in both infrastructure deployment and SQL query generation.Asset value query logic improvements:
infra/main.bicepandsrc/App/backend/agents/agent_factory.pyhave been clarified. The guidance now explicitly states to always return the SUM of the latest investments for total asset value questions, and to return all latest investments without summing for current asset/investment value questions. This helps ensure more accurate and consistent query responses. [1] [2]Resource tagging enhancements:
createdByparameter is introduced ininfra/main.bicep, which captures the deployer's username and adds it as aCreatedBytag to resource groups. This improves traceability of deployments..github/workflows/CAdeploy.ymlnow passes thecreatedByparameter during resource group creation, ensuring the tag is set during automated deployments.Documentation update:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information