Skip to content

Conversation

@Prekshith-Microsoft
Copy link
Contributor

Purpose

This pull request introduces improvements to asset value query instructions, adds a new createdBy parameter for resource tagging, and makes a minor documentation correction. The changes enhance clarity and traceability in both infrastructure deployment and SQL query generation.

Asset value query logic improvements:

  • The instructions for generating T-SQL queries in both infra/main.bicep and src/App/backend/agents/agent_factory.py have been clarified. The guidance now explicitly states to always return the SUM of the latest investments for total asset value questions, and to return all latest investments without summing for current asset/investment value questions. This helps ensure more accurate and consistent query responses. [1] [2]

Resource tagging enhancements:

  • A new createdBy parameter is introduced in infra/main.bicep, which captures the deployer's username and adds it as a CreatedBy tag to resource groups. This improves traceability of deployments.
  • The deployment pipeline in .github/workflows/CAdeploy.yml now passes the createdBy parameter during resource group creation, ensuring the tag is set during automated deployments.

Documentation update:

  • A typo in the troubleshooting documentation was fixed, correcting "ParentResourceNotfound" to "ParentResourceNotFound" for better clarity and alignment with Azure documentation.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit daf0612 into dev Sep 10, 2025
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants