-
Notifications
You must be signed in to change notification settings - Fork 162
feat: AVM WAF Implementation #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Projects, and Web Apps - Created `dependencies.bicep` to manage Cognitive Services account configurations including deployments, private endpoints, and role assignments. - Introduced `keyVaultExport.bicep` for exporting secrets to Azure Key Vault. - Added `project.bicep` for creating AI Foundry projects linked to Cognitive Services. - Developed `web-sites.bicep` for deploying various types of web applications with extensive configuration options. - Implemented `web-sites.config.bicep` to manage app settings and configurations for deployed web apps.
…unt, Search Service related avm changes and Updated the Azure credential retrieval in multiple Python files to include the Managed Identity parameter for improved authentication
…ventions in Bicep modules
…ccess and disable private endpoints
…ole assignments to the existing AiFoundryProject.
… and role assignments
…o parameters file
…just SKU settings, and remove sql elastic pool
Prajwal-Microsoft
approved these changes
Sep 12, 2025
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces new deployment options and infrastructure modules to support sandbox and Well-Architected Framework (WAF) aligned production deployments for the Build-your-own-copilot Solution Accelerator. It adds documentation and configuration for enhanced security, monitoring, and networking, and improves parameter naming consistency across infrastructure files.
Deployment documentation and configuration:
docs/DeploymentGuide.mdto explain sandbox vs. WAF-aligned options, VM credential setup, and best practices for production deployments.infra/main.waf.parameters.jsonfor WAF-aligned, production-ready deployments with stricter security, monitoring, and cost controls.Infrastructure modules and networking:
infra/modules/network.bicepto define a modular, best-practice virtual network, subnets, NSGs, Bastion Host, and Jumpbox VM with configurable parameters for security and monitoring.infra/modules/network/bastionHost.bicepto provision Azure Bastion Host and subnet using AVM modules, supporting diagnostics and telemetry.Parameter naming and resource connection improvements:
infra/main.parameters.json(e.g.,deploymentType→gptModelDeploymentType,azureExistingAIProjectResourceId→existingFoundryProjectResourceId). [1] [2]infra/modules/deploy_aifp_aisearch_connection.bicepfor connecting AI Foundry projects to Azure Cognitive Search resources.infra/modules/keyVaultExport.bicepfor exporting secrets to Azure Key Vault in a standardized way.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation