- 
                Notifications
    You must be signed in to change notification settings 
- Fork 159
fix: Dev to main #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dev to main #706
Changes from 8 commits
4da5f79
              a016314
              ce46763
              0f69898
              536d6c6
              568181a
              090534e
              21e8b9a
              6678b91
              279c5a1
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # AVM Post Deployment Guide | ||
| This document provides guidance on post-deployment steps after deploying the Build Your Own Copilot Accelerator from the [AVM (Azure Verified Modules) repository](https://github.com/Azure/bicep-registry-modules/tree/main/avm/ptn/sa/build-your-own-copilot). | ||
|  | ||
| ## Post Deployment Steps | ||
| 1. Clone the Repository | ||
| First, clone this repository to access the post-deployment scripts: | ||
| ```bash | ||
| git clone https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator.git | ||
| ``` | ||
| ```bash | ||
| cd Build-your-own-copilot-Solution-Accelerator | ||
| ``` | ||
|  | ||
| 2. Import Sample Data -Run bash command printed in the terminal. The bash command will look like the following: | ||
|  | ||
| ```bash | ||
| bash ./infra/scripts/process_sample_data.sh <resourceGroupName> | ||
| ``` | ||
| If the deployment does not exist or has been deleted – The script will prompt you to manually enter the required values | ||
|  | ||
| 3. Add Authentication Provider | ||
|  | ||
| Follow steps in [App Authentication](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/blob/main/docs/AppAuthentication.md) to configure authentication in app service. | ||
| >Note that Authentication changes can take up to 10 minutes. | ||
|  | ||
| 4. Deleting Resources After a Failed Deployment | ||
|  | ||
| Follow steps in [Delete Resource Group](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/blob/main/docs/DeleteResourceGroup.md) if your deployment fails and/or you need to clean up the resources. | ||
|  | ||
| By following these steps, you’ll ensure a smooth transition from deployment to hands-on usage. | 
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|  | @@ -2,16 +2,6 @@ | |||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| # Variables | ||||||||||||||||||||||||||||||
| resourceGroupName="$1" | ||||||||||||||||||||||||||||||
| cosmosDbAccountName="$2" | ||||||||||||||||||||||||||||||
| storageAccount="$3" | ||||||||||||||||||||||||||||||
| fileSystem="$4" | ||||||||||||||||||||||||||||||
| keyvaultName="$5" | ||||||||||||||||||||||||||||||
| sqlServerName="$6" | ||||||||||||||||||||||||||||||
| SqlDatabaseName="$7" | ||||||||||||||||||||||||||||||
| sqlManagedIdentityClientId="$8" | ||||||||||||||||||||||||||||||
| sqlManagedIdentityDisplayName="$9" | ||||||||||||||||||||||||||||||
| aiSearchName="${10}" | ||||||||||||||||||||||||||||||
| aif_resource_id="${11}" | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| # Global variables to track original network access states | ||||||||||||||||||||||||||||||
| original_storage_public_access="" | ||||||||||||||||||||||||||||||
|  | @@ -20,6 +10,7 @@ | |||||||||||||||||||||||||||||
| aif_resource_group="" | ||||||||||||||||||||||||||||||
| aif_account_resource_id="" | ||||||||||||||||||||||||||||||
| # Add global variable for SQL Server public access | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| original_sql_public_access="" | ||||||||||||||||||||||||||||||
| created_sql_allow_all_firewall_rule="false" | ||||||||||||||||||||||||||||||
| original_full_range_rule_present="false" | ||||||||||||||||||||||||||||||
|  | @@ -289,55 +280,116 @@ | |||||||||||||||||||||||||||||
| # Set up trap to ensure cleanup happens on exit | ||||||||||||||||||||||||||||||
| trap cleanup_on_exit EXIT INT TERM | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| # get parameters from azd env, if not provided | ||||||||||||||||||||||||||||||
| if [ -z "$resourceGroupName" ]; then | ||||||||||||||||||||||||||||||
| resourceGroupName=$(azd env get-value RESOURCE_GROUP_NAME) | ||||||||||||||||||||||||||||||
| if az account show &> /dev/null; then | ||||||||||||||||||||||||||||||
| echo "Already authenticated with Azure." | ||||||||||||||||||||||||||||||
| else | ||||||||||||||||||||||||||||||
| echo "Authenticating with Azure CLI..." | ||||||||||||||||||||||||||||||
| az login | ||||||||||||||||||||||||||||||
| echo "Authenticated with Azure CLI." | ||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| # fetch all variables from deployment outputs | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| if [ -z "$cosmosDbAccountName" ]; then | ||||||||||||||||||||||||||||||
| cosmosDbAccountName=$(azd env get-value COSMOSDB_ACCOUNT_NAME) | ||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||
| deploymentName=$(az group show --name "$resourceGroupName" --query "tags.DeploymentName" -o tsv) | ||||||||||||||||||||||||||||||
| echo "Deployment Name (from tag): $deploymentName" | ||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||
| 
     | ||||||||||||||||||||||||||||||
| if [ -z "$deploymentName" ]; then | |
| echo "Error: DeploymentName tag not found in resource group '$resourceGroupName'." | |
| exit 1 | |
| fi | 
    
      
    
      Copilot
AI
    
    
    
      Oct 10, 2025 
    
  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation: some lines use tabs while others use spaces. All lines should use consistent indentation (preferably spaces or tabs consistently throughout the file).
| read -rp "Enter SQL Server Name: " sqlServerName | |
| read -rp "Enter SQL Database Name: " SqlDatabaseName | |
| read -rp "Enter Key Vault Name: " keyvaultName | |
| read -rp "Enter Web App Managed Identity Display Name: " webAppManagedIdentityDisplayName | |
| read -rp "Enter Web App Managed Identity Client ID: " webAppManagedIdentityClientId | |
| read -rp "Enter SQL Managed Identity Display Name: " sqlManagedIdentityDisplayName | |
| read -rp "Enter SQL Managed Identity Client ID: " sqlManagedIdentityClientId | |
| read -rp "Enter SQL Server Name: " sqlServerName | |
| read -rp "Enter SQL Database Name: " SqlDatabaseName | |
| read -rp "Enter Key Vault Name: " keyvaultName | |
| read -rp "Enter Web App Managed Identity Display Name: " webAppManagedIdentityDisplayName | |
| read -rp "Enter Web App Managed Identity Client ID: " webAppManagedIdentityClientId | |
| read -rp "Enter SQL Managed Identity Display Name: " sqlManagedIdentityDisplayName | |
| read -rp "Enter SQL Managed Identity Client ID: " sqlManagedIdentityClientId | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployment name retrieval could fail silently if the tag doesn't exist. Consider adding error handling to check if the deployment name was successfully retrieved before proceeding.