chore: Add AZURE_DEV_COLLECT_TELEMETRY in azure-dev.yml file #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several infrastructure improvements and documentation updates, primarily focused on enhancing Azure resource networking, deployment guidance, and workflow configuration. The most significant changes include a refactor of the networking modules to improve clarity and modularity, updates to private endpoint subnet references, and the addition of a post-deployment guide for users. Workflow and output adjustments further streamline deployment processes and telemetry collection.
Infrastructure and Networking Refactor:
network
module with a more modular setup: separate modules forvirtualNetwork
, Azure Bastion Host, and Jumpbox VM. This improves maintainability and clarity of networking components, and aligns resource references with the new structure.Private Endpoint Subnet Reference Updates:
network!.outputs.subnetPrivateEndpointsResourceId
tovirtualNetwork!.outputs.pepsSubnetResourceId
across multiple modules (Key Vault, AI Services, Cosmos DB, Storage Account, SQL Server, Search Service), ensuring consistency with the new networking structure. [1] [2] [3] [4] [5] [6] [7]Documentation Improvements:
docs/AVMPostDeploymentGuide.md
to provide clear post-deployment instructions, including repository cloning, sample data import, authentication setup, and resource cleanup steps.Workflow and Telemetry Enhancements:
.github/workflows/azure-dev.yml
to remove branch-specific push triggers, and added support for theAZURE_DEV_COLLECT_TELEMETRY
variable, allowing for improved telemetry collection during deployments. [1] [2]Output and Sample Data Script Improvements:
infra/main.bicep
to provide the Azure Subscription ID instead of the managed identity client ID, and updated sample data processing instructions to pass the resource group name as an argument for improved usability. [1] [2] [3]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information