Skip to content

Conversation

NirajC-Microsoft
Copy link
Contributor

Purpose

This pull request introduces several infrastructure improvements and documentation updates, primarily focused on enhancing Azure resource networking, deployment guidance, and workflow configuration. The most significant changes include a refactor of the networking modules to improve clarity and modularity, updates to private endpoint subnet references, and the addition of a post-deployment guide for users. Workflow and output adjustments further streamline deployment processes and telemetry collection.

Infrastructure and Networking Refactor:

  • Replaced the single network module with a more modular setup: separate modules for virtualNetwork, Azure Bastion Host, and Jumpbox VM. This improves maintainability and clarity of networking components, and aligns resource references with the new structure.

Private Endpoint Subnet Reference Updates:

  • Updated all references to private endpoint subnets from network!.outputs.subnetPrivateEndpointsResourceId to virtualNetwork!.outputs.pepsSubnetResourceId across multiple modules (Key Vault, AI Services, Cosmos DB, Storage Account, SQL Server, Search Service), ensuring consistency with the new networking structure. [1] [2] [3] [4] [5] [6] [7]

Documentation Improvements:

  • Added docs/AVMPostDeploymentGuide.md to provide clear post-deployment instructions, including repository cloning, sample data import, authentication setup, and resource cleanup steps.

Workflow and Telemetry Enhancements:

  • Updated .github/workflows/azure-dev.yml to remove branch-specific push triggers, and added support for the AZURE_DEV_COLLECT_TELEMETRY variable, allowing for improved telemetry collection during deployments. [1] [2]

Output and Sample Data Script Improvements:

  • Changed the output in infra/main.bicep to provide the Azure Subscription ID instead of the managed identity client ID, and updated sample data processing instructions to pass the resource group name as an argument for improved usability. [1] [2] [3]
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit c26ac4d into dev Oct 17, 2025
5 of 7 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-azureyml-nj branch October 17, 2025 08:31
Roopan-Microsoft pushed a commit that referenced this pull request Oct 20, 2025
* post deployment script changes

* Updated the network module

* script fix

* update azure.yml

* fix script 1

* Quotacheck fix (#701)

* Add AZURE_DEV_COLLECT_TELEMETRY variable in azure-dev.yml file (#711)

---------

Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Prekshith D J (Persistent Systems Inc) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants