Fix x-ms-request-id header null reference #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 7, 2024 14:23
If no value is found, getFirstHeader returns null. Accessing getValue throws an error.
If no value is found, GetValues returns null. Accessing FirstOrDefault throws an error.
Moq is referenced in the code, but wasn't defined as a package for the project.
Test should run successfully when the x-ms-request-id header null reference is fixed.
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a null reference issue in the CdmHttpClient class.
When attempting to use the
NetworkAdapterto access files on a host, if the host does not return thex-ms-request-idheader in the response, a null reference exception would be thrown. This change fixes the null reference exception by checking to see if the header exists in the response before attempting to access the value.This change also includes a test which will now pass, given that the fix is in place.
In order to run the tests, a reference to
Moqneeded to be added to the Tests project.