Skip to content

Use --all-targets for the no-default-features CI run.#874

Merged
hildebrandmw merged 2 commits intomainfrom
mhildebr/ci
Apr 3, 2026
Merged

Use --all-targets for the no-default-features CI run.#874
hildebrandmw merged 2 commits intomainfrom
mhildebr/ci

Conversation

@hildebrandmw
Copy link
Copy Markdown
Contributor

Slightly more coverage. This basically makes sure that tests still compile in isolation that the workspace level tests mask with feature unification.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI Clippy run that uses --no-default-features to also lint all crate targets, improving coverage and helping catch feature-unification masking issues in workspace builds.

Changes:

  • Add --all-targets to the per-crate cargo clippy --no-default-features CI loop to lint tests/benches/examples as well.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (0ced23d) to head (cc4d3a6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         445      445           
  Lines       84095    84095           
=======================================
+ Hits        75113    75115    +2     
+ Misses       8982     8980    -2     
Flag Coverage Δ
miri 89.32% <ø> (+<0.01%) ⬆️
unittests 89.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-benchmark-core/src/lib.rs 53.33% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw hildebrandmw merged commit 55e157a into main Apr 3, 2026
23 checks passed
@hildebrandmw hildebrandmw deleted the mhildebr/ci branch April 3, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants