Use --all-targets for the no-default-features CI run.#874
Merged
hildebrandmw merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI Clippy run that uses --no-default-features to also lint all crate targets, improving coverage and helping catch feature-unification masking issues in workspace builds.
Changes:
- Add
--all-targetsto the per-cratecargo clippy --no-default-featuresCI loop to lint tests/benches/examples as well.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harsha-simhadri
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=======================================
Coverage 89.31% 89.32%
=======================================
Files 445 445
Lines 84095 84095
=======================================
+ Hits 75113 75115 +2
+ Misses 8982 8980 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arrayka
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly more coverage. This basically makes sure that tests still compile in isolation that the workspace level tests mask with feature unification.