-
Notifications
You must be signed in to change notification settings - Fork 562
build(client): upgrade mocha 10 -> 11 #26086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Nock v14 only intercepts native fetch, not cross-fetch polyfill used in production code, causing tests to timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades mocha from version 10.8.2 to version 11.7.5 across all packages in the client release group. The upgrade includes a necessary change to the test timeout configuration approach to ensure compatibility with mocha v11.
Key Changes:
- Updated mocha dependency from ^10.8.2 to ^11.7.5 across 71 package.json files
- Modified the CI test command to use
FLUID_TEST_TIMEOUTenvironment variable instead of the--timeoutCLI flag - Added cross-env as a dev dependency to support cross-platform environment variable setting
Reviewed changes
Copilot reviewed 87 out of 88 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated mocha to v11.7.5, added cross-env dependency, and changed timeout configuration to use FLUID_TEST_TIMEOUT environment variable |
| packages/utils/tool-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/utils/telemetry-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/utils/odsp-doclib-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/tools/fluid-runner/package.json | Updated mocha devDependency to v11.7.5 |
| packages/tools/devtools/devtools/package.json | Updated mocha devDependency to v11.7.5 |
| packages/tools/devtools/devtools-view/package.json | Updated mocha devDependency to v11.7.5 |
| packages/tools/devtools/devtools-core/package.json | Updated mocha devDependency to v11.7.5 |
| packages/tools/devtools/devtools-browser-extension/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/test-version-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/test-utils/package.json | Updated mocha dependency to v11.7.5 |
| packages/test/test-service-load/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/test-pairwise-generator/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/test-end-to-end-tests/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/stochastic-test-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/snapshots/package.json | Updated mocha in both dependencies and devDependencies to v11.7.5 |
| packages/test/mocha-test-setup/package.json | Updated mocha dependency to v11.7.5 |
| packages/test/local-server-tests/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/local-server-stress-tests/package.json | Updated mocha devDependency to v11.7.5 |
| packages/test/functional-tests/package.json | Updated mocha devDependency to v11.7.5 |
| packages/service-clients/tinylicious-client/package.json | Updated mocha devDependency to v11.7.5 |
| packages/service-clients/odsp-client/package.json | Updated mocha devDependency to v11.7.5 |
| packages/service-clients/end-to-end-tests/odsp-client/package.json | Updated mocha devDependency to v11.7.5 |
| packages/service-clients/end-to-end-tests/azure-client/package.json | Updated mocha devDependency to v11.7.5 |
| packages/service-clients/azure-client/package.json | Updated mocha devDependency to v11.7.5 |
| packages/runtime/test-runtime-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/runtime/runtime-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/runtime/id-compressor/package.json | Updated mocha devDependency to v11.7.5 |
| packages/runtime/datastore/package.json | Updated mocha devDependency to v11.7.5 |
| packages/runtime/container-runtime/package.json | Updated mocha devDependency to v11.7.5 |
| packages/loader/driver-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/loader/container-loader/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/undo-redo/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/tree-agent/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/tree-agent-ses/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/tree-agent-langchain/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/synthesize/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/request-handler/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/react/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/presence/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/fluid-static/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/dds-interceptions/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/client-logger/fluid-telemetry/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/client-logger/app-insights-logger/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/attributor/package.json | Updated mocha devDependency to v11.7.5 |
| packages/framework/aqueduct/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/tinylicious-driver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/routerlicious-urlResolver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/routerlicious-driver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/odsp-urlResolver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/odsp-driver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/local-driver/package.json | Updated mocha devDependency to v11.7.5 |
| packages/drivers/driver-base/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/tree/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/test-dds-utils/package.json | Updated mocha dependency to v11.7.5 |
| packages/dds/task-manager/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/shared-summary-block/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/shared-object-base/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/sequence/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/register-collection/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/pact-map/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/ordered-collection/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/merge-tree/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/matrix/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/map/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/legacy-dds/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/ink/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/counter/package.json | Updated mocha devDependency to v11.7.5 |
| packages/dds/cell/package.json | Updated mocha devDependency to v11.7.5 |
| packages/common/core-utils/package.json | Updated mocha devDependency to v11.7.5 |
| packages/common/core-interfaces/package.json | Updated mocha devDependency to v11.7.5 |
| packages/common/client-utils/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/dds/tree/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/dds/sequence-deprecated/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/dds/ot/sharejs/json1/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/dds/ot/ot/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/PropertyDDS/packages/property-properties/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/PropertyDDS/packages/property-dds/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/PropertyDDS/packages/property-common/package.json | Updated mocha devDependency to v11.7.5 |
| experimental/PropertyDDS/packages/property-changeset/package.json | Updated mocha devDependency to v11.7.5 |
| examples/utils/webpack-fluid-loader/package.json | Updated mocha devDependency to v11.7.5 |
| examples/utils/import-testing/package.json | Updated mocha devDependency to v11.7.5 |
| examples/utils/bundle-size-tests/package.json | Updated mocha devDependency to v11.7.5 |
| examples/data-objects/webflow/package.json | Updated mocha devDependency to v11.7.5 |
| examples/data-objects/table-document/package.json | Updated mocha devDependency to v11.7.5 |
| examples/benchmarks/tablebench/package.json | Updated mocha devDependency to v11.7.5 |
| examples/apps/tree-cli-app/package.json | Updated mocha devDependency to v11.7.5 |
|
Should we be bumping |
Looks like it's already at the latest version. |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
alexvy86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If you'll be around next week, probably ok to merge, otherwise I'd suggest we wait until more of us are around to troubleshoot if necessary.
|
Marking as a draft and will wait until the new year to merge this in case there is unexpected fallout. |
Upgrade mocha to v11.
No changes were needed because a previous change updated the root package.json to pass a setting to mocha via an env variable, so that change is not needed in this PR.