Fix result folder path to work for vscode and npm terminal runs #26092
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where integration test results were being placed in different directories depending on whether tests were run via npm (from package root) or the VS Code test runner (from test directory). The solution detects the current working directory and constructs the appropriate path to ensure results are consistently placed in the same root integration-test-results directory.
Key Changes
- Replaced hardcoded path with a dynamic
getResultsFolderPath()function - Added logic to detect execution context based on
process.cwd() - Added
joinimport fromnode:pathfor proper path construction
noencke
reviewed
Dec 22, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
Author
|
@microsoft-github-policy-service agree |
noencke
approved these changes
Dec 23, 2025
lindsnguyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In tree-agent-langchain, when running integration tests the results are placed in different paths as the code currently doesn't handle having different working directories. This change figures out the the dirname using the new added file and adds the dir
integration-test-resultsdirectory so that the test results can be written there. (Had to add../../src/test/integration-test-resultsbecause the tests actually get run in lib/test not src/test.) Note that this dir was always created whenever integration tests were run but was never tracked by git and should continue to not be.Reviewer Guidance
import.meta.urlbut that wasn't defined in CommonJS. Tried directly using__dirnamebut that isn't defined in ESMdirname.cjsfile that exports the dirname properly.