Skip to content

Conversation

@WillieHabi
Copy link
Contributor

Description

Fixes a bug where loadSummarizerContainerAndMakeSummary wasn't propagating the fullTree flag to trySummarizeWithRetries, causing incremental summaries to always be generated even when full tree summaries were requested via the Fluid.Summarizer.FullTree.OnDemand config flag.

IntrySummarizeWithRetries we hardcode fullTree: false, so this meant the fullTree option was silently ignored when retry logic was enabled.

Solution

  • Added summarizeOptions parameter to trySummarizeWithRetries to accept the caller's options
  • Added summarizeOptions parameter to summarizeOnDemandWithRetries to pass through options
  • Updated summarizeOnDemand to pass summarizeOptions when calling summarizeOnDemandWithRetries

Testing

Added telemetry verification to existing e2e tests to validate that:

  • fullTree is false in Summarize_generate telemetry when config is not set
  • fullTree is true in Summarize_generate telemetry when Fluid.Summarizer.FullTree.OnDemand config is enabled

Copilot AI review requested due to automatic review settings December 23, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the fullTree flag was not properly propagated through the retry logic in the summarizer, causing incremental summaries to always be generated even when full tree summaries were requested via the Fluid.Summarizer.FullTree.OnDemand config flag.

Key Changes:

  • Added summarizeOptions parameter to trySummarizeWithRetries and summarizeOnDemandWithRetries to accept and propagate caller options
  • Updated summarizeOnDemand to pass through summarizeOptions when calling summarizeOnDemandWithRetries
  • Added telemetry validation in e2e tests to verify fullTree flag propagation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/runtime/container-runtime/src/summary/summaryDelayLoadedModule/runningSummarizer.ts Modified trySummarizeWithRetries, summarizeOnDemandWithRetries, and summarizeOnDemand to accept and properly propagate summarizeOptions parameter including the fullTree flag
packages/test/test-end-to-end-tests/src/test/summarization/onDemandSummarizerApi.spec.ts Added telemetry verification to validate fullTree flag is correctly set to false (default) and true (when config enabled) in Summarize_generate events

@jatgarg jatgarg self-requested a review December 23, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants