fix(container-runtime): propagate fullTree flag through trySummarizeWithRetries #26094
+45
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
loadSummarizerContainerAndMakeSummarywasn't propagating thefullTreeflag totrySummarizeWithRetries, causing incremental summaries to always be generated even when full tree summaries were requested via theFluid.Summarizer.FullTree.OnDemandconfig flag.In
trySummarizeWithRetrieswe hardcodefullTree: false, so this meant thefullTreeoption was silently ignored when retry logic was enabled.Solution
summarizeOptionsparameter totrySummarizeWithRetriesto accept the caller's optionssummarizeOptionsparameter tosummarizeOnDemandWithRetriesto pass through optionssummarizeOnDemandto passsummarizeOptionswhen callingsummarizeOnDemandWithRetriesTesting
Added telemetry verification to existing e2e tests to validate that:
fullTreeisfalseinSummarize_generatetelemetry when config is not setfullTreeistrueinSummarize_generatetelemetry whenFluid.Summarizer.FullTree.OnDemandconfig is enabled