Revert "ci: remove unused pipeline variable (#26090)" #26095
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7daa26.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous commit that incorrectly removed the testWorkspace pipeline variable, which is still actively used in multiple end-to-end test pipelines. The removal broke test pipelines that depend on this parameter.
Key changes:
- Restores the
testWorkspaceparameter declaration in the template - Re-adds the parameter to the pipeline variables output for debugging purposes
| default: "@fluid-private/test-end-to-end-tests" | ||
|
|
||
| - name: testWorkspace | ||
| type: string |
There was a problem hiding this comment.
The testWorkspace parameter is missing a default value. Looking at line 573 in the same file, when this template calls include-upload-stage-telemetry.yml, it passes testWorkspace: $(Build.SourcesDirectory). Consider adding a default value of $(Build.SourcesDirectory) to the parameter definition to ensure the parameter has a sensible default when callers don't provide it explicitly.
Suggested change
| type: string | |
| type: string | |
| default: $(Build.SourcesDirectory) |
kian-thompson
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit d7daa26 broke our end-to-end and stress test pipelines because
testWorkspaceis still being used in those pipelines.