-
Notifications
You must be signed in to change notification settings - Fork 562
lts: Fix stress tests runs #26096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lts: Fix stress tests runs #26096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: this whole file is a copy of the one we use today in the main branch to set up a global (to the pipeline run) .npmrc file with all the necessary authentication for the consolidated internal feed where all out dependencies can (should) be retrieved from.
| customRegistry: 'useNpmrc' | ||
| version: 20.19.0 | ||
|
|
||
| - template: /tools/pipelines/templates/include-install-pnpm.yml@self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: moved to bash tasks that use pnpm instead of npm tasks everywhere because npm ones don't respect the global .npmrc file we set up earlier.
| echo Initialize package | ||
| npm init --yes | ||
| echo Generating .npmrc | ||
| echo "registry=https://registry.npmjs.org" >> ./.npmrc | ||
| echo "always-auth=false" >> ./.npmrc | ||
| echo "@fluidframework:registry=${{ variables.feed }}" >> ./.npmrc | ||
| echo "@fluid-experimental:registry=${{ variables.feed }}" >> ./.npmrc | ||
| echo "@fluid-internal:registry=${{ variables.feed }}" >> ./.npmrc | ||
| echo "@ff-internal:registry=https://pkgs.dev.azure.com/fluidframework/internal/_packaging/build/npm/registry/" >> ./.npmrc | ||
| echo "@microsoft:registry=https://pkgs.dev.azure.com/fluidframework/internal/_packaging/office/npm/registry/" >> ./.npmrc | ||
| echo "always-auth=true" >> ./.npmrc | ||
| cat .npmrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: an improved version of this is now done in the new template yaml file added in this PR.
| - task: npmAuthenticate@0 | ||
| displayName: 'npm authenticate (internal feed)' | ||
| # Pin oteljs to a version that doesn't depend on packages that cause issues in our LTS branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we see further issues, I think it would be worth converting this template to use the same approach as main (separate repo which manages the lockfile for the test environment we install packages in). We can create an lts branch there which manages deps for LTS to avoid pinning in main.
This is fine for now though.
Description
For a while, the runs of the stress tests pipeline in the LTS branch have been broken for different reasons. This PR addresses them all so we can continue running that pipeline for the LTS branch.
Main changes:
scoped/unscopedwithtarballsin build-tools a while back).Fixes AB#54754 and AB#54755, plus some other issues hiding behind those.
Reviewer Guidance
The review process is outlined on this wiki page.
Run (msft internal) that shows a successful run of one of the stages with the changes in this PR.