feat(3792): Cannot 'export default' abstract, ambient class or interface#46120
Closed
a-tarasyuk wants to merge 21 commits intomicrosoft:mainfrom
Closed
feat(3792): Cannot 'export default' abstract, ambient class or interface#46120a-tarasyuk wants to merge 21 commits intomicrosoft:mainfrom
a-tarasyuk wants to merge 21 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
The TypeScript team hasn't accepted the linked issue #3792. If you can get it accepted, this PR will have a better chance of being reviewed. |
…/enums/declared classes
weswigham
reviewed
Mar 15, 2023
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
This looks OK to me, but I'm going to formally defer to @rbuckton on this - I think he'll have some strong opinions on how and where decorators should be parsed for these constructs (and if they should be) that are probably worth considering. export default abstract class F {} in particular will likely have spec-described behavior, since it's a native syntax with an extra keyword thrown in.
Contributor
Author
|
@weswigham Thank you for the feedback 🚀. Okay, I'll be glad to hear @rbuckton's thoughts. |
github-project-automation
bot
moved this from Waiting on reviewers
to Done
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3792
Fixes #3792 (comment)