Narrow non-directly related weak types by intersecting them with candidates by Andarist · Pull Request #58520 · microsoft/TypeScript

Andarist · 2024-05-13T17:20:14Z

…idates

Andarist · 2024-05-13T17:23:02Z

tests/baselines/reference/typeGuardIntersectionTypes.types

 >         : ^ ^^     ^^^^^^^^^^^^^^^^
->beast : Legged
->      : ^^^^^^
+>beast : Beast & Legged


This is essentially the same test case as the added one. Without the change, we can't access beast.wings here (even though it's permitted before narrowing).

Regardless of that, I find it useful to include the @danvk's test case here as I could include the ticket reference in a clean manner above it.

jakebailey · 2024-05-13T17:23:05Z

@typescript-bot test it

typescript-bot · 2024-05-13T17:23:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-13T17:44:09Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-13T17:45:24Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58520/merge:

Everything looks good!

typescript-bot · 2024-05-13T18:05:14Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,341k (± 0.10%)}	_{194,224k (± 0.93%)}	_{+1,883k (+ 0.98%)}	_192,526k	_195,958k	_{p=0.031 n=6}
_{Parse Time}	_{1.29s (± 0.94%)}	_{1.30s (± 1.16%)}	_~	_1.27s	_1.31s	_{p=0.218 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.28%)}	_{9.57s (± 0.27%)}	_~	_9.52s	_9.59s	_{p=0.569 n=6}
_{Emit Time}	_{2.63s (± 0.85%)}	_{2.63s (± 0.68%)}	_~	_2.60s	_2.65s	_{p=0.935 n=6}
_{Total Time}	_{14.20s (± 0.30%)}	_{14.21s (± 0.27%)}	_~	_14.16s	_14.25s	_{p=0.685 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,106k (± 0.00%)}	_{1,222,098k (± 0.01%)}	_~	_1,221,985k	_1,222,175k	_{p=1.000 n=6}
_{Parse Time}	_{6.80s (± 0.56%)}	_{6.79s (± 0.88%)}	_~	_6.72s	_6.89s	_{p=0.518 n=6}
_{Bind Time}	_{1.87s (± 0.71%)}	_{1.88s (± 0.75%)}	_~	_1.86s	_1.90s	_{p=0.360 n=6}
_{Check Time}	_{31.32s (± 0.71%)}	_{31.27s (± 0.38%)}	_~	_31.13s	_31.43s	_{p=0.810 n=6}
_{Emit Time}	_{14.76s (± 0.54%)}	_{14.75s (± 0.42%)}	_~	_14.69s	_14.83s	_{p=0.686 n=6}
_{Total Time}	_{54.75s (± 0.49%)}	_{54.69s (± 0.19%)}	_~	_54.56s	_54.83s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,349	_1,961,349	_~	_~	_~	_{p=1.000 n=6}
_Types	_696,910	_696,910	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,778,098k (± 0.00%)}	_{1,778,092k (± 0.00%)}	_~	_1,778,030k	_1,778,131k	_{p=0.873 n=6}
_{Parse Time}	_{6.78s (± 0.18%)}	_{6.79s (± 0.20%)}	_~	_6.77s	_6.81s	_{p=0.180 n=6}
_{Bind Time}	_{2.31s (± 0.24%)}	_{2.31s (± 0.59%)}	_~	_2.29s	_2.33s	_{p=1.000 n=6}
_{Check Time}	_{57.23s (± 0.33%)}	_{57.14s (± 0.50%)}	_~	_56.70s	_57.50s	_{p=0.575 n=6}
_{Emit Time}	_0.14s	_{0.14s (± 2.88%)}	_~	_0.14s	_0.15s	_{p=0.405 n=6}
_{Total Time}	_{66.47s (± 0.28%)}	_{66.38s (± 0.44%)}	_~	_65.92s	_66.74s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,211	_259,211	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,361,593k (± 2.59%)}	_{2,336,453k (± 0.02%)}	_~	_2,335,921k	_2,337,211k	_{p=0.298 n=6}
_{Parse Time}	_{5.03s (± 1.36%)}	_{5.03s (± 0.91%)}	_~	_4.96s	_5.09s	_{p=1.000 n=6}
_{Bind Time}	_{1.88s (± 0.64%)}	_{1.86s (± 0.88%)}	_~	_1.85s	_1.89s	_{p=0.160 n=6}
_{Check Time}	_{33.71s (± 0.22%)}	_{33.84s (± 0.17%)}	_{+0.13s (+ 0.40%)}	_33.76s	_33.92s	_{p=0.010 n=6}
_{Emit Time}	_{2.66s (± 2.61%)}	_{2.64s (± 2.48%)}	_~	_2.52s	_2.70s	_{p=0.747 n=6}
_{Total Time}	_{43.29s (± 0.28%)}	_{43.40s (± 0.28%)}	_~	_43.19s	_43.53s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,120	_1,221,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,211	_259,211	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,939k (± 0.03%)}	_{2,412,782k (± 0.04%)}	_~	_2,411,846k	_2,414,480k	_{p=0.689 n=6}
_{Parse Time}	_{6.25s (± 0.33%)}	_{6.28s (± 1.58%)}	_~	_6.14s	_6.42s	_{p=0.574 n=6}
_{Bind Time}	_{2.06s (± 0.96%)}	_{2.04s (± 0.48%)}	_{-0.02s (- 0.89%)}	_2.03s	_2.05s	_{p=0.048 n=6}
_{Check Time}	_{40.30s (± 0.23%)}	_{40.25s (± 0.30%)}	_~	_40.05s	_40.40s	_{p=0.810 n=6}
_{Emit Time}	_{3.18s (± 1.77%)}	_{3.18s (± 2.59%)}	_~	_3.05s	_3.26s	_{p=0.810 n=6}
_{Total Time}	_{51.79s (± 0.31%)}	_{51.77s (± 0.50%)}	_~	_51.32s	_52.01s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,716	_256,716	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,288	_104,288	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{425,803k (± 0.01%)}	_{425,843k (± 0.02%)}	_~	_425,741k	_426,013k	_{p=0.230 n=6}
_{Parse Time}	_{3.35s (± 1.00%)}	_{3.36s (± 0.46%)}	_~	_3.34s	_3.38s	_{p=0.359 n=6}
_{Bind Time}	_{1.31s (± 0.64%)}	_{1.30s (± 0.97%)}	_~	_1.28s	_1.31s	_{p=0.530 n=6}
_{Check Time}	_{17.86s (± 0.32%)}	_{17.84s (± 0.24%)}	_~	_17.76s	_17.87s	_{p=0.468 n=6}
_{Emit Time}	_{1.35s (± 1.01%)}	_{1.36s (± 1.11%)}	_~	_1.33s	_1.37s	_{p=0.619 n=6}
_{Total Time}	_{23.86s (± 0.34%)}	_{23.85s (± 0.20%)}	_~	_23.77s	_23.90s	_{p=0.872 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,888k (± 0.02%)}	_{369,869k (± 0.03%)}	_~	_369,769k	_370,027k	_{p=1.000 n=6}
_{Parse Time}	_{2.83s (± 0.53%)}	_{2.84s (± 1.03%)}	_~	_2.79s	_2.87s	_{p=0.415 n=6}
_{Bind Time}	_{1.59s (± 0.79%)}	_{1.59s (± 0.47%)}	_~	_1.58s	_1.60s	_{p=0.676 n=6}
_{Check Time}	_{15.64s (± 0.26%)}	_{15.72s (± 0.41%)}	_{+0.08s (+ 0.54%)}	_15.63s	_15.79s	_{p=0.037 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.06s (± 0.20%)}	_{20.15s (± 0.33%)}	_~	_20.07s	_20.22s	_{p=0.065 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,821,504	_2,821,508	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_957,195	_957,198	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,993,753k (± 0.00%)}	_{2,993,703k (± 0.00%)}	_{-50k (- 0.00%)}	_2,993,582k	_2,993,741k	_{p=0.045 n=6}
_{Parse Time}	_{17.02s (± 0.30%)}	_{17.01s (± 0.25%)}	_~	_16.97s	_17.09s	_{p=0.872 n=6}
_{Bind Time}	_{5.03s (± 0.59%)}	_{5.04s (± 0.32%)}	_~	_5.03s	_5.07s	_{p=0.454 n=6}
_{Check Time}	_{89.20s (± 0.33%)}	_{88.98s (± 0.29%)}	_~	_88.67s	_89.34s	_{p=0.230 n=6}
_{Emit Time}	_{28.74s (± 0.71%)}	_{28.77s (± 1.33%)}	_~	_28.35s	_29.42s	_{p=0.748 n=6}
_{Total Time}	_{139.99s (± 0.32%)}	_{139.80s (± 0.37%)}	_~	_139.35s	_140.79s	_{p=0.149 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,534k (± 0.01%)}	_{410,624k (± 0.01%)}	_{+91k (+ 0.02%)}	_410,549k	_410,699k	_{p=0.020 n=6}
_{Parse Time}	_{4.76s (± 0.80%)}	_{4.77s (± 0.58%)}	_~	_4.73s	_4.80s	_{p=0.687 n=6}
_{Bind Time}	_{2.07s (± 1.10%)}	_{2.08s (± 0.53%)}	_~	_2.07s	_2.09s	_{p=0.508 n=6}
_{Check Time}	_{20.94s (± 0.22%)}	_{20.96s (± 0.31%)}	_~	_20.84s	_21.03s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.77s (± 0.24%)}	_{27.81s (± 0.31%)}	_~	_27.64s	_27.87s	_{p=0.171 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,639	_524,639	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,906	_178,906	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,705k (± 0.02%)}	_{462,722k (± 0.01%)}	_~	_462,668k	_462,851k	_{p=0.630 n=6}
_{Parse Time}	_{3.10s (± 0.52%)}	_{3.11s (± 0.64%)}	_~	_3.08s	_3.14s	_{p=0.514 n=6}
_{Bind Time}	_{1.16s (± 0.44%)}	_{1.16s (± 1.04%)}	_~	_1.15s	_1.18s	_{p=1.000 n=6}
_{Check Time}	_{18.32s (± 0.36%)}	_{18.36s (± 0.39%)}	_~	_18.30s	_18.49s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.58s (± 0.32%)}	_{22.64s (± 0.42%)}	_~	_22.55s	_22.81s	_{p=0.377 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-13T19:01:20Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58520/merge:

Everything looks good!

…with-candidates

Narrow non-directly related weak types by intersecting them with cand…

01bd4e8

…idates

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 13, 2024

Andarist commented May 13, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into intersect-weak-types-…

86863a7

…with-candidates

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 16, 2025

add test case

73b5904

RyanCavanaugh mentioned this pull request Jan 16, 2025

Type guard and assertion do not properly refine union types with optional properties #60979

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Narrow non-directly related weak types by intersecting them with candidates#58520

Narrow non-directly related weak types by intersecting them with candidates#58520
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Andarist:intersect-weak-types-with-candidates

Andarist commented May 13, 2024 •

edited

Loading

Uh oh!

Andarist May 13, 2024

Uh oh!

jakebailey commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024 •

edited

Loading

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024

tsc

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Andarist commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andarist May 13, 2024

Choose a reason for hiding this comment

Uh oh!

jakebailey commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

typescript-bot commented May 13, 2024

tsc

Uh oh!

typescript-bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Andarist commented May 13, 2024 •

edited

Loading

typescript-bot commented May 13, 2024 •

edited

Loading