Improve CSS Typed OM property return types#60837
Closed
ophirbucai wants to merge 1 commit intomicrosoft:mainfrom
Closed
Improve CSS Typed OM property return types#60837ophirbucai wants to merge 1 commit intomicrosoft:mainfrom
ophirbucai wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Narrow down return type of `StylePropertyMapReadOnly.get()` to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes: - CSSUnitValue - CSSKeywordValue - CSSTransformValue - Default: CSSStyleValue
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Collaborator
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow down return type of
StylePropertyMapReadOnly.get()to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes:This change provides better type safety and autocompletion when working with
computedStyleMap().Changes:
CSSStyleValueTests:
hereby runtestscompleted successfully