Enhance isJS check in getNewImportFixes function#62840
Open
johnsoncodehk wants to merge 2 commits intomicrosoft:mainfrom
Open
Enhance isJS check in getNewImportFixes function#62840johnsoncodehk wants to merge 2 commits intomicrosoft:mainfrom
johnsoncodehk wants to merge 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the isJS check in the getNewImportFixes function to better support Language Service plugins (like Vue.js language tools) that add custom file types via LS plugins. The change prioritizes checking scriptKind over file extension to determine if a file should be treated as JavaScript, ensuring consistent JsdocTypeImport behavior.
Key changes:
- Import
ScriptKindenum for script kind checking - Remove the top-level
isJsvariable that only checked file extension - Move JS determination logic into the conditional block where it's needed, checking
scriptKindfirst withhasJSFileExtensionas fallback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Pay as u use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vuejs/language-tools#4582
In
getNewImportFixes, prioritize checking scriptKind over file extension forisJs. This ensures consistentJsdocTypeImportbehavior for file types added via LS plugins.