Reorder Array#reduce overloads for better type inference#62878
Closed
majiayu000 wants to merge 1 commit intomicrosoft:mainfrom
Closed
Reorder Array#reduce overloads for better type inference#62878majiayu000 wants to merge 1 commit intomicrosoft:mainfrom
majiayu000 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
b8b0e55 to
ca2a562
Compare
) The generic overload `reduce<U>(callbackfn, initialValue: U): U` is now placed before `reduce(callbackfn, initialValue: T): T` to ensure better type inference when the initial value type differs from the array element type. This fixes cases where `U` is assignable to `T` (e.g., `number` assignable to `{}`), which previously caused the non-generic overload to match incorrectly. Fixes microsoft#7014 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ca2a562 to
84a6bbf
Compare
Author
|
Closing this PR as the implementation needs further review. The JSDoc comments were not properly moved with their corresponding function overloads. Will resubmit after proper analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reorders the
Array#reduceandArray#reduceRightmethod overloads to fix incorrect type inference when the initial value type differs from the array element type.Problem
When using
reducewith aninitialValuewhose typeUis assignable to the array element typeT(e.g.,numberassignable to{}), TypeScript incorrectly matches thereduce(callbackfn, initialValue: T): Toverload instead of the more specific genericreduce<U>(callbackfn, initialValue: U): Uoverload.Example (from issue):
Solution
Move the generic overload
reduce<U>before thereduce(initialValue: T)overload:Files Changed
src/lib/es5.d.ts-ReadonlyArrayandArrayinterfacessrc/lib/esnext.iterator.d.ts-IteratorinterfaceTest plan
reduce-related tests passFixes #7014
🤖 Generated with Claude Code