Fix accidental module replacements in tests#62890
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Dec 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes accidental module-to-namespace replacements that occurred during cherry-picking changes to the tsgo-port branch. The changes restore the original module-related code and test baselines that were unintentionally replaced with namespace-related content.
Key Changes
- Restored original module keyword in test case asiPreventsParsingAsNamespace04.ts
- Removed duplicate namespace declarations in parseInvalidNames.ts test
- Corrected namespace name from placeholder "$1" to actual Unicode identifier in collisionCodeGenModuleWithUnicodeNames test files
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cases/conformance/internalModules/moduleDeclarations/asiPreventsParsingAsNamespace04.ts | Restored module in {} from incorrectly changed namespace in {} |
| tests/cases/compiler/parseInvalidNames.ts | Removed duplicate namespace 100 {} declarations that were accidentally inserted |
| tests/baselines/reference/parseInvalidNames.types | Updated baseline to reflect removal of duplicate namespace declarations |
| tests/baselines/reference/parseInvalidNames.symbols | Updated baseline to reflect removal of duplicate namespace declarations |
| tests/baselines/reference/parseInvalidNames.js | Updated baseline to reflect removal of duplicate namespace declarations |
| tests/baselines/reference/parseInvalidNames.errors.txt | Updated error count from 28 to 21 errors after removing duplicates |
| tests/baselines/reference/collisionCodeGenModuleWithUnicodeNames.types | Corrected namespace name from placeholder "$1" to full Unicode identifier |
| tests/baselines/reference/collisionCodeGenModuleWithUnicodeNames.symbols | Corrected namespace name from placeholder "$1" to full Unicode identifier |
| tests/baselines/reference/collisionCodeGenModuleWithUnicodeNames.js | Corrected namespace name from placeholder "$1" to full Unicode identifier in generated code |
| tests/baselines/reference/collisionCodeGenModuleWithUnicodeNames.errors.txt | Removed error file as the corrected namespace resolves the previous error |
| tests/baselines/reference/asiPreventsParsingAsNamespace04.types | Updated baseline to reflect restoration of module keyword |
| tests/baselines/reference/asiPreventsParsingAsNamespace04.symbols | Updated baseline to reflect restoration of module keyword |
| tests/baselines/reference/asiPreventsParsingAsNamespace04.js | Updated baseline to reflect restoration of module keyword |
| tests/baselines/reference/asiPreventsParsingAsNamespace04.errors.txt | Removed error file as the corrected code no longer produces errors |
gabritto
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cherry-picking the module changes to the tsgo-port branch, I noticed these few that appear to have been unintentional / redundant.