Skip to content

FI main to develop#1358

Merged
5an7y-Microsoft merged 60 commits intodevelopfrom
main
Mar 19, 2026
Merged

FI main to develop#1358
5an7y-Microsoft merged 60 commits intodevelopfrom
main

Conversation

@5an7y-Microsoft
Copy link
Contributor

@5an7y-Microsoft 5an7y-Microsoft commented Mar 18, 2026

No description provided.

5an7y and others added 30 commits June 27, 2025 12:59
@5an7y
Create Sample Issue template
d10e550
@5an7y
Merge pull request #1 from 5an7y/sample-based-issue-template
fce97a3 
Create Sample Issue template
@5an7y
Update sample_issue.yml
841bf5e 
fixed
@5an7y
Action to auto generate the sample issues template
b279aaa
@5an7y
Action to auto tag the codeowner.
b83d9d2
@5an7y
id fix
737e921
@5an7y
Merge pull request #2 from 5an7y/sample-based-issue-template
9e1ed2c 
Sample based issue template
@5an7y
import requests module
268a017
@5an7y
Merge pull request #4 from 5an7y/sample-based-issue-template
7ac40cb 
import requests module
@5an7y
Correct regex expression
e48795a
@5an7y
Merge pull request #6 from 5an7y/sample-based-issue-template
ba50875 
Correct regex expression
@5an7y
Made the query more efficient
4c463c3
@5an7y
Merge pull request #8 from 5an7y/sample-based-issue-template
5d1436e 
Made the query more efficient
@5an7y
Selected path bug fix
12d6551
@5an7y
Merge pull request #10 from 5an7y/sample-based-issue-template
b3eac5f 
Selected path bug fix
@5an7y
Fix selected path bug
69b234c
@5an7y
Merge pull request #12 from 5an7y/sample-based-issue-template
4525b22 
Fix selected path bug
@5an7y
Sort the area in the issue template
1cef4c5
@5an7y
Merge pull request #14 from 5an7y/sample-based-issue-template
c75fc92 
Sort the area in the issue template
@5an7y
Correct codeowner path
454b597
@5an7y
Merge pull request #15 from 5an7y/sample-based-issue-template
668fe2d 
Correct codeowner path
@5an7y
Correct sample issue path
44faaa2
@5an7y
Merge pull request #16 from 5an7y/sample-based-issue-template
8012049 
Correct sample issue path
@5an7y
Order sample issue
9b45042
@5an7y
Merge pull request #18 from 5an7y/sample-based-issue-template
cb0261e 
Order sample issue
@5an7y
Merge branch 'main' into main
152cf49
@5an7y
Merge branch 'main' into main
396d2f0
@5an7y
Merge branch 'microsoft:main' into main
9a897b9
@5an7y
Reference PR head
a0d6b25
@5an7y-Microsoft
Merge pull request #1319 from 5an7y/main
b45d3d6 
PR to test changes from original branch. No harm done since this is done to my users branch
5an7y-Microsoft and others added 24 commits October 3, 2025 12:02
@5an7y-Microsoft
Merge pull request #1310 from 5an7y/main
b472de3 
New issues template based on sample.
@v-junyli
Merge pull request #1331 from microsoft/user/vjunyli/BulkCloseIssues
57ea2d0 
adding workflow to bulk cleanup stale issues older than 1 year
@v-junyli
Increase operations-per-run to 400 and the stale threshold from 7 to 31
6d81ee3
@v-junyli
Merge pull request #1332 from microsoft/user/vjunyli/FixStaleWF
c74e591 
Increase operations-per-run to 400 and the stale threshold
@v-junyli
use PAT_TOKEN and add dry-run for testing purpose.
9e8335f
@v-junyli
Merge pull request #1333 from microsoft/user/vjunyli/FixStaleWF
2a7a31d 
use PAT_TOKEN and add dry-run for testing purpose.
@v-junyli
reversing the PAT_TOKEN and dry-run change
6ac765a
@v-junyli
Merge pull request #1334 from microsoft/user/vjunyli/FixStaleWF
7615e29 
reversing the PAT_TOKEN and dry-run change
@v-junyli
disable schedule and deleted the closing issue part
5b11934
@v-junyli
Merge pull request #1336 from microsoft/user/vjunyli/disableWorkflow
1d89a15 
disable schedule and deleted the closing issue part
@darugeri
New SDCAVAD sample.
6fa87d3
removed the space after newline which seems to be bug in c++ 23 not i…
caee83c 
…n samples
@prashantchahar
Merge pull request #1346 from microsoft/pc_loadletter_0302
76e03fc 
removed the space after newline which seems to be a bug in c++ 23
@v-junyli
update Script to be compatible with vs2026
c96af8a
@v-junyli
Merge pull request #1348 from microsoft/user/vjunyli/vs2026updateScript
9607307 
update Script to be compatible with vs2026
@5an7y-Microsoft
Merge pull request #1340 from darugeri/master
2977346 
New SDCAVAD sample
@5an7y
Disable tag-codeowner-on-issue workflow
24f84c1 
Added 'if: false' to the job to prevent it from running while preserving the code.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@5an7y-Microsoft
Merge pull request #1351 from microsoft/user/jvalesmena/disable-tag-o…
3e597cc 
…wners

Disable tag-codeowner-on-issue workflow
@5an7y
WDK test infra changes
ed0aa30
@5an7y-Microsoft
Merge pull request #1353 from microsoft/user/jvalesmena/wdk-test-infr…
a28a071 
…a-changes

Making INF verifier and option to the build all samples PS script
Initial plan
8683573
@5an7y-Microsoft
Fix RCE vulnerability: pass issue body/number via env vars instead of…
f204d70 
… direct interpolation

Co-authored-by: 5an7y-Microsoft <219205893+5an7y-Microsoft@users.noreply.github.com>
@5an7y-Microsoft
Merge pull request #1 from 5an7y-Microsoft/copilot/fix-rce-vulnerabil…
ba5c475 
…ity-in-workflow

Fix RCE in tag-codeowner-on-issue workflow via environment variables
@5an7y-Microsoft
Merge pull request #1355 from 5an7y-Microsoft/main
925b258 
Fix RCE vulnerability in workflow using environment variables
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 18, 2026
View reviewed changes
audio/SoundWire/Samples/SdcaVad/SdcaVXu/ModuleCircuit.cpp
//
// Add circuit identifiers.
//
AcxCircuitInitSetComponentId(circuitInit, &SDCAXU_MODULECIRCUIT_GUID);

Check failure

Code scanning / CodeQL

Result of call that may return NULL dereferenced unconditionally

In SdcaXu_CreateModuleCircuit result of [call](1) to [AcxCircuitInitAllocate](2) is dereferenced here and may be null.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/render.cpp
// We could also change the formats supported by the host pin here, but a DSP will typically determine
// those formats and do appropriate processing.
ACXPIN bridgePin = AcxCircuitGetPinById(AcxPinGetCircuit(Pin), DspPinTypeBridge);
NTSTATUS status = ReplicateFormatsForPin(bridgePin, TargetCircuit, TargetPinId);

Check failure

Code scanning / CodeQL

Result of call that may return NULL dereferenced unconditionally

In DspR_EvtPinConnected result of [call](1) to [AcxCircuitGetPinById](2) is dereferenced here and may be null.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/device.cpp
//
// Add factory identifiers.
//
RETURN_NTSTATUS_IF_FAILED(AcxFactoryCircuitInitAssignComponentUri(factoryInit, &dspFactoryUri));

Check failure

Code scanning / CodeQL

Result of call that may return NULL dereferenced unconditionally

In Dsp_AddFactoryCircuit result of [call](1) to [AcxFactoryCircuitInitAllocate](2) is dereferenced here and may be null.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/capture.cpp
// stream in Stereo.
NTSTATUS status;
ACXPIN hostPin = AcxCircuitGetPinById(AcxPinGetCircuit(Pin), DspCapturePinTypeHost);
status = ReplicateFormatsForPin(hostPin, TargetCircuit, TargetPinId);

Check failure

Code scanning / CodeQL

Result of call that may return NULL dereferenced unconditionally

In DspC_EvtPinConnected result of [call](1) to [AcxCircuitGetPinById](2) is dereferenced here and may be null.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/WaveReader.cpp
ntStatus = ReadHeaderAndFillBuffer();

Done:
(void)KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/ToneGenerator.cpp
m_PartialFrameBytes = m_FrameSize - (DWORD)length;

Done:
KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/CircuitHelper.cpp
RETURN_NTSTATUS_IF_TRUE(pinConnection != nullptr, status);

pinConnectionSize = (ULONG)info;
pinConnection = (PKSPIN_PHYSICALCONNECTION)ExAllocatePool2(POOL_FLAG_NON_PAGED, pinConnectionSize, DRIVER_TAG);

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
KSPIN_PHYSICALCONNECTION
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVCodec/render.cpp
DECLARE_CONST_UNICODE_STRING(circuitUri, EXT_RENDER_CIRCUIT_URI);

#pragma prefast(suppress:__WARNING_ALIASED_MEMORY_LEAK, "memory is freed by scope_exit")
PSDCAXU_ACX_CIRCUIT_CONFIG exCircuitConfig = (PSDCAXU_ACX_CIRCUIT_CONFIG)ExAllocatePool2(

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
_SDCAXU_ACX_CIRCUIT_CONFIG
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVCodec/capture.cpp
DECLARE_CONST_UNICODE_STRING(circuitUri, EXT_CAPTURE_CIRCUIT_URI);

#pragma prefast(suppress:__WARNING_ALIASED_MEMORY_LEAK, "memory is freed by scope_exit")
PSDCAXU_ACX_CIRCUIT_CONFIG exCircuitConfig = (PSDCAXU_ACX_CIRCUIT_CONFIG)ExAllocatePool2(

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
_SDCAXU_ACX_CIRCUIT_CONFIG
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/streamengine.cpp
RETURN_NTSTATUS_IF_FAILED(RtlSizeTMult(PacketCount, sizeof(ACX_RTPACKET), &packetsSize));

#pragma prefast(suppress:__WARNING_MEMORY_LEAK, "On error packets gets freed inside scope_exit.")
packets = (PACX_RTPACKET)ExAllocatePool2(POOL_FLAG_NON_PAGED, packetsSize, DRIVER_TAG);

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes.

Memory allocation of [_ACX_RTPACKET](1) includes uninitialized padding bytes.
@5an7y-Microsoft 5an7y-Microsoft marked this pull request as ready for review March 18, 2026 18:59
@5an7y-Microsoft 5an7y-Microsoft requested review from a team as code owners March 18, 2026 18:59
@5an7y-Microsoft 5an7y-Microsoft merged commit 21d5686 into develop Mar 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@5an7y-Microsoft @5an7y @v-junyli @darugeri @prashantchahar