fix(react-drawer): update drawer scroll state when content changes #35210
+89
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
changed the title
marcosmoura
changed the title
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
marcosmoura
commented
Sep 19, 2025
| @@ -1 +1,3 @@ | |||
| /** Jest test setup file. */ | |||
| const ResizeObserver = require('resize-observer-polyfill'); | |||
There was a problem hiding this comment.
First time we use ResizeObserver for our components, so we need to mock it for the test env since Jest doesn't support ResizeObserver
There was a problem hiding this comment.
Could you please make sure that it's get picked up by react-integration-tester (rit)?
dmytrokirpa
reviewed
Sep 30, 2025
| "@fluentui/scripts-api-extractor": "*", | ||
| "@fluentui/scripts-cypress": "*" | ||
| "@fluentui/scripts-cypress": "*", | ||
| "resize-observer-polyfill": "1.5.1" |
There was a problem hiding this comment.
following the monorepo single version policy, so we should probably add this to the root package.json as well, correct @Hotell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
DrawerBody was not accounting for content change to calculate the scroll state, that is responsible to define the separator.
New Behavior
DrawerBody now has a ResizeObserver to detect when the content changes, at least for when the height changes.
Related Issue(s)
DrawerscrollStatedoes not update whenDrawerBodycontent changes size #34324