Open
Conversation
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
rzhao271
approved these changes
Mar 11, 2026
aeschli
previously approved these changes
Mar 11, 2026
Tyriar
requested changes
Mar 12, 2026
Comment on lines
49
to
55
| switch (message) { | ||
| case ConoutWorkerMessage.READY: | ||
| this._onReady.fire(); | ||
| return; | ||
| default: | ||
| console.warn('Unexpected ConoutWorkerMessage', message); | ||
| case ConoutWorkerMessage.READY: | ||
| this._onReady.fire(); | ||
| return; | ||
| default: | ||
| console.warn('Unexpected ConoutWorkerMessage', message); | ||
| } |
Member
There was a problem hiding this comment.
Can we remove whatever rule caused this?
Contributor
Author
There was a problem hiding this comment.
Done — removed the indent rule from eslint.config.js and reverted the indentation in windowsConoutConnection.ts back to its original state (e178adc).
Contributor
|
@copilot remove indent rule and undo indentation change in windowsConoutConnection |
…n indentation Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the project from ESLint 6 +
@typescript-eslintv2 to ESLint 9 +@typescript-eslintv8, and upgrades TypeScript to v5.Changes
Config
eslint.config.js(ESLint 9 flat config) replaces the old.eslintrc.js.eslintrc.jspackage.jsonlint script: removed deprecated-c .eslintrc.jsand--ext .tsflags (ESLint 9 uses flat config by default and infers extensions fromfilesglobs)Dependencies updated
eslint@typescript-eslint/eslint-plugin@typescript-eslint/parsertypescriptRules updated
Removed rules that were dropped in
@typescript-eslintv8 (and replaced with core ESLint equivalents or already covered by other rules):@typescript-eslint/class-name-casing→ covered by existing@typescript-eslint/naming-convention@typescript-eslint/interface-name-prefix→ covered by existing@typescript-eslint/naming-convention@typescript-eslint/quotes→ replaced by corequotes@typescript-eslint/semi→ replaced by coresemi@typescript-eslint/member-delimiter-style→ dropped (formatting-only, removed in v6)@typescript-eslint/type-annotation-spacing→ dropped (formatting-only, removed in v6)@typescript-eslint/indent→ dropped (not replaced; formatting-only and not enforced)Source fixes (auto-fixed)
src/eventEmitter2.ts:IListener<T>[]→Array<IListener<T>>(array-type rule)src/windowsTerminal.ts:{ run: () => void }[]→Array<{ run: () => void }>(array-type rule)Verification
npm run lintpassesnpm run buildpasses💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.