Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 23, 2024

Bumps ruff from 0.7.3 to 0.8.4.

Release notes

Sourced from ruff's releases.

0.8.4

Release Notes

Preview features

  • [airflow] Extend AIR302 with additional functions and classes (#15015)
  • [airflow] Implement moved-to-provider-in-3 for modules that has been moved to Airflow providers (AIR303) (#14764)
  • [flake8-use-pathlib] Extend check for invalid path suffix to include the case "." (PTH210) (#14902)
  • [perflint] Fix panic in PERF401 when list variable is after the for loop (#14971)
  • [perflint] Simplify finding the loop target in PERF401 (#15025)
  • [pylint] Preserve original value format (PLR6104) (#14978)
  • [ruff] Avoid false positives for RUF027 for typing context bindings (#15037)
  • [ruff] Check for ambiguous pattern passed to pytest.raises() (RUF043) (#14966)

Rule changes

  • [flake8-bandit] Check S105 for annotated assignment (#15059)
  • [flake8-pyi] More autofixes for redundant-none-literal (PYI061) (#14872)
  • [pydocstyle] Skip leading whitespace for D403 (#14963)
  • [ruff] Skip SQLModel base classes for mutable-class-default (RUF012) (#14949)

Bug

  • [perflint] Parenthesize walrus expressions in autofix for manual-list-comprehension (PERF401) (#15050)

Server

  • Check diagnostic refresh support from client capability which enables dynamic configuration for various editors (#15014)

Contributors

... (truncated)

Changelog

Sourced from ruff's changelog.

0.8.4

Preview features

  • [airflow] Extend AIR302 with additional functions and classes (#15015)
  • [airflow] Implement moved-to-provider-in-3 for modules that has been moved to Airflow providers (AIR303) (#14764)
  • [flake8-use-pathlib] Extend check for invalid path suffix to include the case "." (PTH210) (#14902)
  • [perflint] Fix panic in PERF401 when list variable is after the for loop (#14971)
  • [perflint] Simplify finding the loop target in PERF401 (#15025)
  • [pylint] Preserve original value format (PLR6104) (#14978)
  • [ruff] Avoid false positives for RUF027 for typing context bindings (#15037)
  • [ruff] Check for ambiguous pattern passed to pytest.raises() (RUF043) (#14966)

Rule changes

  • [flake8-bandit] Check S105 for annotated assignment (#15059)
  • [flake8-pyi] More autofixes for redundant-none-literal (PYI061) (#14872)
  • [pydocstyle] Skip leading whitespace for D403 (#14963)
  • [ruff] Skip SQLModel base classes for mutable-class-default (RUF012) (#14949)

Bug

  • [perflint] Parenthesize walrus expressions in autofix for manual-list-comprehension (PERF401) (#15050)

Server

  • Check diagnostic refresh support from client capability which enables dynamic configuration for various editors (#15014)

0.8.3

Preview features

  • Fix fstring formatting removing overlong implicit concatenated string in expression part (#14811)
  • [airflow] Add fix to remove deprecated keyword arguments (AIR302) (#14887)
  • [airflow]: Extend rule to include deprecated names for Airflow 3.0 (AIR302) (#14765 and #14804)
  • [flake8-bugbear] Improve error messages for except* (B025, B029, B030, B904) (#14815)
  • [flake8-bugbear] itertools.batched() without explicit strict (B911) (#14408)
  • [flake8-use-pathlib] Dotless suffix passed to Path.with_suffix() (PTH210) (#14779)
  • [pylint] Include parentheses and multiple comparators in check for boolean-chained-comparison (PLR1716) (#14781)
  • [ruff] Do not simplify round() calls (RUF046) (#14832)
  • [ruff] Don't emit used-dummy-variable on function parameters (RUF052) (#14818)
  • [ruff] Implement if-key-in-dict-del (RUF051) (#14553)
  • [ruff] Mark autofix for RUF052 as always unsafe (#14824)
  • [ruff] Teach autofix for used-dummy-variable about TypeVars etc. (RUF052) (#14819)

Rule changes

  • [flake8-bugbear] Offer unsafe autofix for no-explicit-stacklevel (B028) (#14829)
  • [flake8-pyi] Skip all type definitions in string-or-bytes-too-long (PYI053) (#14797)
  • [pyupgrade] Do not report when a UTF-8 comment is followed by a non-UTF-8 one (UP009) (#14728)

... (truncated)

Commits
  • 3bb0dac Bump version to 0.8.4 (#15064)
  • 40cba5d [red-knot] Cleanup various todo_type!() messages (#15063)
  • 596d80c [perflint] Parenthesize walrus expressions in autofix for `manual-list-comp...
  • d8b9a36 Disable actionlint hook by default when running pre-commit locally (#15061)
  • 85e71ba [flake8-bandit] Check S105 for annotated assignment (#15059)
  • 2802cbd Don't special-case class instances in unary expression inference (#15045)
  • ed2bce6 [red-knot] Report invalid exceptions (#15042)
  • f0012df Fix typos in RUF043.py (#15044)
  • 0fc4e8f Introduce InferContext (#14956)
  • ac81c72 [ruff] Ambiguous pattern passed to pytest.raises() (RUF043) (#14966)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.3 to 0.8.4.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.7.3...0.8.4)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Dec 23, 2024
@justinchuby justinchuby self-assigned this Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
16838 19 16819 3780
View the top 1 failed tests by shortest run time
::onnxscript.rewriter.onnxruntime.xformers._test_models
Stack Traces | 0s run time
No failure message available
View the full list of 2 ❄️ flaky tests
tests.eager_mode_test.TestEagerModeArguments_0_reference_runtime::test_function_input_and_attribute_by_kwargs_out_of_order

Flake rate in main: 39.28% (Passed 12587 times, Failed 8144 times)

Stack Traces | 0.002s run time
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:91: in run
    res = self._run(x, y)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:139: in _run
    res = (convert_from_ml_dtypes(res[0]),)
..../test_onnx_weekly/lib/python3.11.../onnx/reference/custom_element_types.py:50: in convert_from_ml_dtypes
    return array.view(dtype=dtype)
E   ValueError: Changing the dtype of a 0d array is only supported if the itemsize is unchanged

The above exception was the direct cause of the following exception:
tests/eager_mode_test.py:115: in test_function_input_and_attribute_by_kwargs_out_of_order
    self.assertEqual(add_with_alpha(alpha=3.0, other=2.0, this=1.0), 7.0)
onnxscript/values.py:576: in __call__
    return evaluator.default().eval_function(self, args, kwargs)
onnxscript/evaluator.py:307: in eval_function
    result = function.function(*adapted_args, **adapted_kwargs)
tests/eager_mode_test.py:59: in add_with_alpha
    other = op.Mul(other, alpha)
.../onnx_opset/_impl/opset14.py:696: in Mul
    return op(*self._prepare_inputs(schema, A, B))
onnxscript/values.py:304: in __call__
    return evaluator.default().eval(schema, args, kwargs)
onnxscript/evaluator.py:194: in eval
    outputs = self._eval(schema, inputs, attributes, closure)
onnxscript/evaluator.py:524: in _eval
    result = session.run(None, session_run_input)
..../test_onnx_weekly/lib/python3.11.../onnx/reference/reference_evaluator.py:593: in run
    outputs = node.run(*inputs, **linked_attributes)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:114: in run
    res = OpRunBinary.run(self, x, y)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:93: in run
    raise TypeError(
E   TypeError: Issues with types <class 'numpy.ndarray'>, <class 'numpy.ndarray'> (binary operator 'Mul').
tests.eager_mode_test.TestEagerModeArguments_0_reference_runtime::test_function_all_input_by_kwargs

Flake rate in main: 39.28% (Passed 12587 times, Failed 8144 times)

Stack Traces | 0.002s run time
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:91: in run
    res = self._run(x, y)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:139: in _run
    res = (convert_from_ml_dtypes(res[0]),)
..../test_onnx_weekly/lib/python3.11.../onnx/reference/custom_element_types.py:50: in convert_from_ml_dtypes
    return array.view(dtype=dtype)
E   ValueError: Changing the dtype of a 0d array is only supported if the itemsize is unchanged

The above exception was the direct cause of the following exception:
tests/eager_mode_test.py:109: in test_function_all_input_by_kwargs
    self.assertEqual(add_with_alpha(this=1.0, other=2.0), 3.0)
onnxscript/values.py:576: in __call__
    return evaluator.default().eval_function(self, args, kwargs)
onnxscript/evaluator.py:307: in eval_function
    result = function.function(*adapted_args, **adapted_kwargs)
tests/eager_mode_test.py:59: in add_with_alpha
    other = op.Mul(other, alpha)
.../onnx_opset/_impl/opset14.py:696: in Mul
    return op(*self._prepare_inputs(schema, A, B))
onnxscript/values.py:304: in __call__
    return evaluator.default().eval(schema, args, kwargs)
onnxscript/evaluator.py:194: in eval
    outputs = self._eval(schema, inputs, attributes, closure)
onnxscript/evaluator.py:524: in _eval
    result = session.run(None, session_run_input)
..../test_onnx_weekly/lib/python3.11.../onnx/reference/reference_evaluator.py:593: in run
    outputs = node.run(*inputs, **linked_attributes)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:114: in run
    res = OpRunBinary.run(self, x, y)
..../test_onnx_weekly/lib/python3.11.../reference/ops/_op.py:93: in run
    raise TypeError(
E   TypeError: Issues with types <class 'numpy.ndarray'>, <class 'numpy.ndarray'> (binary operator 'Mul').

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@justinchuby justinchuby enabled auto-merge (squash) December 27, 2024 20:10
@justinchuby justinchuby merged commit 3c75013 into main Dec 30, 2024
20 of 39 checks passed
@justinchuby justinchuby deleted the dependabot/pip/requirements/lintrunner/ruff-0.8.4 branch December 30, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

Development

Successfully merging this pull request may close these issues.

1 participant