-
Notifications
You must be signed in to change notification settings - Fork 84
Merge input and output shape when removing identity #2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
+ Coverage 70.07% 70.08% +0.01%
==========================================
Files 223 223
Lines 26263 26266 +3
Branches 2600 2601 +1
==========================================
+ Hits 18404 18409 +5
+ Misses 6948 6947 -1
+ Partials 911 910 -1 ☔ View full report in Codecov by Sentry. |
Should this be added for other ops, eg. CastLike, Abs, etc. ? Essentially whenever the output is a known PyTorch value that has complete shape, and when the input has dynamic dims that the onnx shape inference engine doesn’t yet handle. |
All those simplifications rewrite it to |
I don't understand why in the test |
Set input type to output type if input type is None.
Turns out we should relay the type as well |
Following microsoft/onnxscript#2588. Handle shape info as well. Signed-off-by: Justin Chu <[email protected]>
Similar with #2578, for this case: