Skip to content

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 3, 2025

The goal is to have no overloads and remove the PyTorch dispatcher. Right now there are still the following ops that need to be addressed:

Registering private function: aten::as_strided
Registering private function: aten::embedding_bag
Registering private function: aten::embedding_bag.padding_idx
Registering overload for function: aten::index.Tensor
Registering overload for function: aten::_unsafe_index.Tensor
Registering overload for function: aten::index_put

I did a bit of cleaning up in tests and torchlib as well.

#2580

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added this to the 0.5.4 milestone Oct 3, 2025
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Oct 3, 2025
Signed-off-by: Justin Chu <[email protected]>
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 79.62963% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.32%. Comparing base (075fc4d) to head (fbc0540).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 80.00% 19 Missing and 12 partials ⚠️
onnxscript/function_libs/torch_lib/ops/nn.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
+ Coverage   69.97%   70.32%   +0.35%     
==========================================
  Files         222      222              
  Lines       26324    26224     -100     
  Branches     2609     2624      +15     
==========================================
+ Hits        18420    18442      +22     
+ Misses       6992     6865     -127     
- Partials      912      917       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby self-assigned this Oct 6, 2025
@justinchuby
Copy link
Collaborator Author

Revert changes to roll

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby enabled auto-merge (squash) October 8, 2025 22:18
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Oct 8, 2025
@justinchuby justinchuby merged commit 9ab7527 into main Oct 8, 2025
29 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Oct 8, 2025
@justinchuby justinchuby deleted the justinchu/consolidate-overloads branch October 8, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants