Skip to content

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 13, 2025

Operator add may take in python scalar sometimes (and doesn't have dtype). This PR splits the implementation out so that it is handled differently.

Operator add may take in python scalar sometimes.

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Oct 13, 2025
@justinchuby justinchuby added this to the 0.5.4 milestone Oct 13, 2025
@justinchuby justinchuby enabled auto-merge (squash) October 13, 2025 22:36
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.39%. Comparing base (32a61f4) to head (d2f08bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
- Coverage   70.39%   70.39%   -0.01%     
==========================================
  Files         222      222              
  Lines       26275    26281       +6     
  Branches     2629     2629              
==========================================
+ Hits        18496    18500       +4     
- Misses       6859     6861       +2     
  Partials      920      920              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit dd14682 into main Oct 13, 2025
31 checks passed
@justinchuby justinchuby deleted the justinchu/operator-add branch October 13, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

2 participants