Skip to content

Conversation

@AyoubMDL
Copy link
Contributor

Fixes #2547. I've kept the same ops as in #2555.



class RemoveOptionalBiasQLinearConvTest(_RemoveOptionalBiasTestBase):
def _get_test_model(self, zero_bias):

Check warning

Code scanning / CodeQL

Signature mismatch in overriding method Warning

This method requires 2 positional arguments, whereas overridden
_RemoveOptionalBiasTestBase._get_test_model
requires at least 5.
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 97.01493% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.46%. Comparing base (80f28c9) to head (920a5d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ipt/rewriter/rules/common/_remove_optional_bias.py 95.12% 1 Missing and 1 partial ⚠️
...ewriter/rules/common/_remove_optional_bias_test.py 97.82% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
+ Coverage   70.32%   70.46%   +0.13%     
==========================================
  Files         222      224       +2     
  Lines       26438    26572     +134     
  Branches     2632     2637       +5     
==========================================
+ Hits        18593    18723     +130     
- Misses       6926     6928       +2     
- Partials      919      921       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyoubMDL AyoubMDL force-pushed the remove-optional-bias branch from 9735091 to 4547bd2 Compare October 16, 2025 17:11
Removes optional bias when it is all zero from Conv, ConvTranspose,
Gemm and QLinearConv operations.
@AyoubMDL AyoubMDL force-pushed the remove-optional-bias branch from 4547bd2 to 920a5d3 Compare October 18, 2025 14:04
@justinchuby justinchuby enabled auto-merge (squash) October 18, 2025 16:36
@justinchuby justinchuby merged commit 8a94ad6 into microsoft:main Oct 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Rewrite rule: Remove optional bias

3 participants