-
Notifications
You must be signed in to change notification settings - Fork 162
(RFC) Write a diagnostic marker when provisioning the VMGS #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
(RFC) Write a diagnostic marker when provisioning the VMGS #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This RFC introduces a diagnostic provisioning marker to VMGS files that records metadata about how the file was initially provisioned. The marker captures information such as the provisioner entity (OpenHCL, HCL, etc.), vTPM version and configuration details, and the HCL commit hash.
Key changes:
- New
ProvisioningMarkerstruct andVmgsProvisionerenum invmgs_formatto define the diagnostic marker format - vTPM-related constants moved to
tpm_protocolfor reuse across components - Logic in OpenHCL to write the provisioning marker when a VMGS file is provisioned
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vm/vmgs/vmgs_format/src/lib.rs | Defines the ProvisioningMarker struct, VmgsProvisioner enum, and adds new file ID for the marker |
| vm/vmgs/vmgs_format/Cargo.toml | Adds tpm_protocol dependency for TpmVersion type |
| vm/vmgs/vmgs/src/vmgs_impl.rs | Tracks whether VMGS was formatted due to failure, adds accessor method |
| vm/vmgs/vmgs/Cargo.toml | Reorders dependency (cosmetic change) |
| vm/devices/tpm/tpm_protocol/src/lib.rs | Defines TpmVersion enum and default TPM configuration constants |
| vm/devices/tpm/tpm_protocol/Cargo.toml | Adds dependencies needed for the new enum (open_enum, zerocopy) |
| openhcl/underhill_core/src/worker.rs | Writes provisioning marker to VMGS when file is provisioned |
| openhcl/underhill_core/Cargo.toml | Adds dependencies for tpm_protocol and vmgs_format |
We want to leave a marker in a VMGS file that indicates that it was provisioned originally by HCL, with some diagnostic details (vTPM version, etc.) This is intended to be information-only.