test: use tmp_path instead of tmpdir fixture #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mxschmitt merged 1 commit into microsoft:main from mxschmitt:test/use-tmp_path

Jun 10, 2025

Member

mxschmitt commented Jun 10, 2025 •

edited

Loading

Before we were using this:

https://github.com/pytest-dev/pytest/blob/9e9633de9da7a9fab03b4bba3a326bf85b412050/src/_pytest/legacypath.py#L306-L320

We should use this instead:

https://github.com/pytest-dev/pytest/blob/9e9633de9da7a9fab03b4bba3a326bf85b412050/src/_pytest/tmpdir.py#L258-L263

The old one didn't use 'Path' instances which makes trouble sometimes.


          test: use tmp_path instead of tmpdir fixture

c429cde

dgozman approved these changes

View reviewed changes

mxschmitt merged commit 5476582 into microsoft:main

36 of 38 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet